Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.Http] Remove .NET 6 target #2152

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

joegoldman2
Copy link
Contributor

Changes

Remove .NET 6 target which will be very soon out of support.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@joegoldman2 joegoldman2 requested a review from a team as a code owner October 3, 2024 12:27
@github-actions github-actions bot added comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http perf Performance related labels Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.57%. Comparing base (71655ce) to head (4e5dfdb).
Report is 486 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2152      +/-   ##
==========================================
- Coverage   73.91%   73.57%   -0.35%     
==========================================
  Files         267       11     -256     
  Lines        9615      840    -8775     
==========================================
- Hits         7107      618    -6489     
+ Misses       2508      222    -2286     
Flag Coverage Δ
unittests-Instrumentation.Http 73.57% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 275 files with indirect coverage changes

@Kielek Kielek merged commit 3f23c16 into open-telemetry:main Oct 3, 2024
58 checks passed
@joegoldman2 joegoldman2 deleted the http-tfm branch October 3, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http perf Performance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants