Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.GrpcNetClient] Remove .NET 6 target #2150

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

joegoldman2
Copy link
Contributor

Changes

Remove .NET 6 target which will be very soon out of support.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@joegoldman2 joegoldman2 requested a review from a team as a code owner October 3, 2024 10:47
@github-actions github-actions bot added the comp:instrumentation.grpcnetclient Things related to OpenTelemetry.Instrumentation.GrpcNetClient label Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.61%. Comparing base (71655ce) to head (f5c6215).
Report is 479 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2150      +/-   ##
==========================================
+ Coverage   73.91%   79.61%   +5.69%     
==========================================
  Files         267        5     -262     
  Lines        9615      103    -9512     
==========================================
- Hits         7107       82    -7025     
+ Misses       2508       21    -2487     
Flag Coverage Δ
unittests-Instrumentation.GrpcNetClient 79.61% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 269 files with indirect coverage changes

@Kielek Kielek merged commit 1a61e93 into open-telemetry:main Oct 3, 2024
59 checks passed
@joegoldman2 joegoldman2 deleted the grpcnetclient-tfm branch October 3, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.grpcnetclient Things related to OpenTelemetry.Instrumentation.GrpcNetClient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants