[Instrumentation.AWS] Move adding request and response info to AWSTracingPipelineHandler #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cingPipelineHandler
github-actions
bot
added
the
comp:instrumentation.aws
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2137 +/- ##
===========================================
+ Coverage 73.91% 86.09% +12.17%
===========================================
Files 267 34 -233
Lines 9615 906 -8709
===========================================
- Hits 7107 780 -6327
+ Misses 2508 126 -2382
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
ppittle
reviewed
Oct 14, 2024
| @@ -18,6 +18,7 @@ internal static class AWSSemanticConventions | |||
| public const string AttributeAWSBedrockDataSourceId = "aws.bedrock.data_source.id"; | |||
| public const string AttributeAWSBedrockGuardrailId = "aws.bedrock.guardrail.id"; | |||
| public const string AttributeAWSBedrockKnowledgeBaseId = "aws.bedrock.knowledge_base.id"; | |||
| public const string AttributeAWSeBedrock = "aws_bedrock"; | |||
There was a problem hiding this comment.
typo? Should be AttributeAWSBedrock?
There was a problem hiding this comment.
Is this used anywhere? (I don't have the full code base in front me)
There was a problem hiding this comment.
ppittle
approved these changes
Oct 24, 2024
muhammad-othman
deleted the
aws-instrumentation-fix-request-specific-info
branch
This was referenced Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2108
Changes
This pull request addresses issue #2108 where AWS SDK request info were not being applied as expected. The logic for adding these info has been moved to the
AWSTracingPipelineHandlerwhich is executed early in the AWS SDK pipeline in order to manipulate outgoing requests objects before they are serialized.I didn't add additional tests here since we will need to examine the request at a specific part of the AWS request pipeline to validate these changes, but I ran the same code that was provided in the issue and the
traceparentwas sent and received properlyMerge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes