Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] core-1.10.0-beta.1 release updates #2121

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

opentelemetrybot
Copy link
Collaborator

Note: This PR was opened automatically by the core version update workflow.

Merge once packages are available on NuGet and the build passes.

Changes

  • Sets OpenTelemetryCoreLatestPrereleaseVersion in Common.props to 1.10.0-beta.1.

@opentelemetrybot opentelemetrybot added the release Related to the release process label Sep 30, 2024
@opentelemetrybot opentelemetrybot requested a review from a team as a code owner September 30, 2024 21:41
@github-actions github-actions bot added the infra Infra work - CI/CD, code coverage, linters label Sep 30, 2024
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kielek
Copy link
Contributor

Kielek commented Oct 1, 2024

@CodeBlanch,
we have 2 layers of the issues.

  1. Geneva-tests issues related to [api] Mark SetStatus & GetStatus ActivityExtensions obsolete opentelemetry-dotnet#5781. It is not obvious in couple places. Partially we should probably ignore warnings. It will be great if you can handle this part.
  2. Following tests should drop test for .net 6. Or we could temporary disable warning for them by SuppressTfmSupportBuildWarnings.
  • OpenTelemetry.Exporter.Geneva.Benchmarks (net6.0),
  • OpenTelemetry.Instrumentation.AspNetCore.Benchmarks (net6.0),
  • OpenTelemetry.Instrumentation.Http.Benchmarks (net6.0),
  • OpenTelemetry.Instrumentation.Process.Tests (net6.0),
  • OpenTelemetry.Instrumentation.Runtime.Tests (net6.0),
  • OpenTelemetry.Instrumentation.Wcf.Tests (net6.0)
    What is the better option in your opinion?

@github-actions github-actions bot added perf Performance related comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva comp:instrumentation.aspnetcore Things related to OpenTelemetry.Instrumentation.AspNetCore comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http labels Oct 1, 2024
@github-actions github-actions bot added comp:instrumentation.process Things related to OpenTelemetry.Instrumentation.Process comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf labels Oct 1, 2024
@CodeBlanch CodeBlanch merged commit f24e67f into main Oct 1, 2024
218 checks passed
@CodeBlanch CodeBlanch deleted the release/post-core-1.10.0-beta.1-update branch October 1, 2024 20:40
@CodeBlanch
Copy link
Member

@Kielek I removed usage of OpenTelemetryExporterInMemoryLatestPreReleasePkgVer to unblock this. Not sure why things were pinned on prerelease version of InMemory exporter in the first place 🤣

We'll need to deal with the removal of net6.0 and the obsoletions before we can take 1.10.0 stable though. Seems like progress is being made on net6.0 so that is good 👍 The obsoletions, not sure. We could just suppress them initially because searching through the code lots of hits on SetStatus and RecordException. We could also start moving projects to OpenTelemetryCoreLatestPrereleaseVersion (one-by-one) and fix these up so we're ready for stable without suppressions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva comp:instrumentation.aspnetcore Things related to OpenTelemetry.Instrumentation.AspNetCore comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http comp:instrumentation.process Things related to OpenTelemetry.Instrumentation.Process comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf infra Infra work - CI/CD, code coverage, linters perf Performance related release Related to the release process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants