Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[geneva] Rename metric transports #2119

Merged

Conversation

CodeBlanch
Copy link
Member

[Split off from #2113]

Changes

  • Rename the metric transports in GenevaExporter to prepare for addition of MetricUnixUserEventsDataTransport

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated

@CodeBlanch CodeBlanch requested a review from a team as a code owner September 30, 2024 17:16
@github-actions github-actions bot added the comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva label Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.09%. Comparing base (71655ce) to head (51c68ae).
Report is 458 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2119       +/-   ##
===========================================
- Coverage   73.91%   59.09%   -14.82%     
===========================================
  Files         267       44      -223     
  Lines        9615     3924     -5691     
===========================================
- Hits         7107     2319     -4788     
+ Misses       2508     1605      -903     
Flag Coverage Δ
unittests-Exporter.Geneva 59.09% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...Metrics/OtlpProtobuf/OtlpProtobufMetricExporter.cs 69.23% <100.00%> (ø)
...metry.Exporter.Geneva/Metrics/TlvMetricExporter.cs 74.45% <100.00%> (ø)
...s/Transport/MetricUnixDomainSocketDataTransport.cs 85.71% <100.00%> (ø)
...ransport/MetricWindowsEventTracingDataTransport.cs 60.00% <100.00%> (ø)

... and 248 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit 5559a6c into open-telemetry:main Sep 30, 2024
59 checks passed
@CodeBlanch CodeBlanch deleted the geneva-metric-transport-renames branch September 30, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants