Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter.InfluxDB] Replace .NET 6 target with .NET 8 #2116

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

joegoldman2
Copy link
Contributor

Changes

Replace .NET 6 target, which will be very soon out of support, with .NET 8.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@joegoldman2 joegoldman2 requested a review from a team as a code owner September 28, 2024 14:29
@github-actions github-actions bot requested a review from Havret September 28, 2024 14:29
@github-actions github-actions bot added the comp:exporter.influxdb Things related to OpenTelemetry.Exporter.InfluxDB label Sep 28, 2024
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.88%. Comparing base (71655ce) to head (770ecb3).
Report is 459 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2116       +/-   ##
===========================================
+ Coverage   73.91%   95.88%   +21.96%     
===========================================
  Files         267        7      -260     
  Lines        9615      243     -9372     
===========================================
- Hits         7107      233     -6874     
+ Misses       2508       10     -2498     
Flag Coverage Δ
unittests-Exporter.InfluxDB 95.88% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 264 files with indirect coverage changes

@github-actions github-actions bot removed the comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva label Sep 30, 2024
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit 6026a05 into open-telemetry:main Sep 30, 2024
58 checks passed
@joegoldman2 joegoldman2 deleted the influxdb-tfm branch October 1, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.influxdb Things related to OpenTelemetry.Exporter.InfluxDB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants