Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Sync-up .editorconfig with main repo #2093

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

CodeBlanch
Copy link
Member

Changes

  • Updates .editorconfig for recent changes done in the main repo. Enables some things as suggestions. Quiets some spammy stuff which was previously enabled but generally ignored (use primary constructor suggestion, folder structure should match namespace suggestion). Deals with warnings that came with .NET 9 SDK in main repo and will likely pop up here

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)

@CodeBlanch CodeBlanch requested a review from a team as a code owner September 23, 2024 21:50
@github-actions github-actions bot added the comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva label Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.04%. Comparing base (71655ce) to head (402a114).
Report is 445 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2093      +/-   ##
==========================================
- Coverage   73.91%   65.04%   -8.88%     
==========================================
  Files         267       35     -232     
  Lines        9615     3596    -6019     
==========================================
- Hits         7107     2339    -4768     
+ Misses       2508     1257    -1251     
Flag Coverage Δ
unittests-Exporter.Geneva 65.04% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ry.Exporter.Geneva/External/TraceLoggingDynamic.cs 22.46% <ø> (ø)

... and 252 files with indirect coverage changes

@Kielek
Copy link
Contributor

Kielek commented Sep 24, 2024

@CodeBlanch, I think that changes in this files should trigger build for all files (modification of detect-changes step is needed).

EDIT: nvm. lint is executed.

@Kielek Kielek merged commit 1139fac into open-telemetry:main Sep 24, 2024
59 checks passed
@CodeBlanch CodeBlanch deleted the repo-editorconfig-sync-up branch September 24, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants