Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#201 AWSEKSResourceDetector - Validate ClusterName/ContainerID independently before adding it to the resource #205

Merged
merged 2 commits into from
Feb 14, 2022
Merged

#201 AWSEKSResourceDetector - Validate ClusterName/ContainerID independently before adding it to the resource #205

merged 2 commits into from
Feb 14, 2022

Conversation

swetharavichandrancisco
Copy link
Contributor

@swetharavichandrancisco swetharavichandrancisco commented Feb 8, 2022 •
edited
Loading

#201 AWSEKSResourceDetector - Validate ClusterName/ContainerID independently before adding it to the resource

  • Validates ClusterName/ContainerID independently before adding it to the resource
  • Includes bug fix - IsEKSProcess should return non-null auth value to confirm if its running in EKS environment.
  • Handled exceptions separately with more error information
  • Added Unit Tests

@swetharavichandrancisco
open-telemetry#201 - AWSEKSResourceDetector - Validate ClusterName/Co…
43a74d7 
…ntainerID independently before adding it to the resource

- Validates ClusterName/ContainerID independently before adding it to the resource
- Includes bug fix - IsEKSProcess should return non-null auth value to confirm if its running in EKS environment.
- Handled exceptions separately with more error information
- Added Unit Tests
@swetharavichandrancisco swetharavichandrancisco requested a review from a team February 8, 2022 19:56
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 8, 2022 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@swetharavichandrancisco swetharavichandrancisco changed the title https://github.com/open-telemetry/opentelemetry-dotnet-contrib/issues… #201 AWSEKSResourceDetector - Validate ClusterName/ContainerID independently before adding it to the resource Feb 8, 2022
srprash
srprash approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@srprash srprash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change. LGTM.

@srprash srprash merged commit 5f4fce1 into open-telemetry:main Feb 14, 2022
@pavankrish123 pavankrish123 mentioned this pull request Feb 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srprash srprash srprash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swetharavichandrancisco @srprash