Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.AspNet] Add IConfiguration support #1976

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Jul 25, 2024

Fixes #1960

Changes

  • Updates AspNet to retrieve OTEL_DOTNET_EXPERIMENTAL_ASPNET_DISABLE_URL_QUERY_REDACTION using IConfiguration

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@CodeBlanch CodeBlanch requested a review from a team July 25, 2024 18:13
@github-actions github-actions bot added the comp:instrumentation.aspnet Things related to OpenTelemetry.Instrumentation.AspNet label Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 92.68293% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.75%. Comparing base (71655ce) to head (2a978d2).
Report is 369 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1976      +/-   ##
==========================================
+ Coverage   73.91%   76.75%   +2.83%     
==========================================
  Files         267       15     -252     
  Lines        9615      357    -9258     
==========================================
- Hits         7107      274    -6833     
+ Misses       2508       83    -2425     
Flag Coverage Δ
unittests-Instrumentation.AspNet 76.75% <92.68%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...mentation.AspNet/MeterProviderBuilderExtensions.cs 94.11% <100.00%> (-5.89%) ⬇️
...entation.AspNet/TracerProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
...Implementation/AspNetInstrumentationEventSource.cs 82.35% <66.66%> (+5.42%) ⬆️
...tation.AspNet/AspNetTraceInstrumentationOptions.cs 86.66% <75.00%> (ø)

... and 267 files with indirect coverage changes

@Kielek Kielek merged commit fc10347 into open-telemetry:main Jul 25, 2024
54 checks passed
@CodeBlanch CodeBlanch deleted the aspnet-iconfiguration-support branch July 25, 2024 18:25
ezhang6811 pushed a commit to ezhang6811/opentelemetry-dotnet-contrib that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.aspnet Things related to OpenTelemetry.Instrumentation.AspNet
Projects
None yet
3 participants