[Instrumentation.AWS] Update AWS SDK Activity Tags (#1857) #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yiran29 - Could you please sign the CLA? #1865 (comment) |
Kielek
added
the
comp:instrumentation.aws
birojnayak
approved these changes
Jun 5, 2024
ppittle
approved these changes
Jun 5, 2024
vishweshbankwar
approved these changes
Jun 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1865 +/- ##
===========================================
+ Coverage 73.91% 87.56% +13.64%
===========================================
Files 267 12 -255
Lines 9615 201 -9414
===========================================
- Hits 7107 176 -6931
+ Misses 2508 25 -2483
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Kielek
reviewed
Jun 5, 2024
src/OpenTelemetry.Instrumentation.AWS/Implementation/AWSTracingPipelineHandler.cs
Outdated
Show resolved
Hide resolved
Kielek
approved these changes
Jun 5, 2024
rajkumar-rangaraj
approved these changes
Jun 5, 2024
cijothomas
approved these changes
Jun 6, 2024
srprash
approved these changes
Jun 6, 2024
|
@yiran29, could you please handle comment from @cijothomas? #1865 (review) Then the PR can be merged. |
@Kielek I have updated the CHANGELOG for AWS Instrumentation. Thanks! |
Kielek
reviewed
Jun 12, 2024
Kielek
reviewed
Jun 12, 2024
Kielek
reviewed
Jun 12, 2024
vastin
added a commit
to aws-observability/aws-otel-dotnet-instrumentation
that referenced
this pull request
Jun 27, 2024
- miss rpc.system in AWS SDK span. fixed in open-telemetry/opentelemetry-dotnet-contrib#1865 and pending for release. - miss leading / in span.DisplayName of http server span. - env var OTEL_EXPORTER_OTLP_TRACES_ENDPOINT doesn't take effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Opentelemetry Semantic Conventions for AWS SDK: https://opentelemetry.io/docs/specs/semconv/cloud-providers/aws-sdk, update Activity Tags for
rpc.service, rpc.system, rpc.method.Fixes #1857
Changes
Currently AWS SDK instrumentation did not set RPC Activity Tags as mentioned in https://opentelemetry.io/docs/specs/semconv/cloud-providers/aws-sdk/, this change will add missing tags. Changes have been tested with OpenTelemetry.Instrumentation.AWS.Tests