Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StackExchangeRedisInstrumentationOptions xml docs #1842

Merged
merged 3 commits into from
May 24, 2024

Conversation

gao-artur
Copy link
Contributor

@gao-artur gao-artur commented May 24, 2024

Fixes #.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.00%. Comparing base (71655ce) to head (51c4f9b).
Report is 274 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1842      +/-   ##
==========================================
- Coverage   73.91%   71.00%   -2.92%     
==========================================
  Files         267        5     -262     
  Lines        9615      269    -9346     
==========================================
- Hits         7107      191    -6916     
+ Misses       2508       78    -2430     
Flag Coverage Δ
unittests-Instrumentation.StackExchangeRedis 71.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...eRedis/StackExchangeRedisInstrumentationOptions.cs 100.00% <ø> (ø)

... and 266 files with indirect coverage changes

@gao-artur gao-artur marked this pull request as ready for review May 24, 2024 15:43
@gao-artur gao-artur requested a review from a team May 24, 2024 15:43
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Please remove changelog, and we are good to merge

This reverts commit 93908d0.
@gao-artur
Copy link
Contributor Author

Done

@cijothomas cijothomas merged commit 1d112c8 into open-telemetry:main May 24, 2024
57 checks passed
@CodeBlanch CodeBlanch added the comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants