-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Resources.Azure] Rename Azure detector namespace #1840
Merged
Kielek
merged 9 commits into
open-telemetry:main
from
matt-hensley:rename-azure-detector
May 27, 2024
Merged
[Resources.Azure] Rename Azure detector namespace #1840
Kielek
merged 9 commits into
open-telemetry:main
from
matt-hensley:rename-azure-detector
May 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajkumar-rangaraj
approved these changes
May 23, 2024
joegoldman2
reviewed
May 24, 2024
src/OpenTelemetry.Resources.Azure/AzureResourceBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
May 24, 2024
@@ -2,6 +2,19 @@ | |||
|
|||
## Unreleased | |||
|
|||
* **Breaking Change**: Renamed package from `OpenTelemetry.ResourceDetectors.Azure` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 very nicely written changelog.
cijothomas
approved these changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks a lot!
joegoldman2
reviewed
May 24, 2024
src/OpenTelemetry.Resources.Azure/AzureResourceBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
joegoldman2
reviewed
May 24, 2024
src/OpenTelemetry.Resources.Azure/AzureResourceBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
joegoldman2
reviewed
May 24, 2024
…ey/opentelemetry-dotnet-contrib into rename-azure-detector
Co-authored-by: joegoldman2 <[email protected]>
Kielek
approved these changes
May 27, 2024
Kielek
added
the
comp:resources.azure
Things related to OpenTelemetry.Resources.Azure
label
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Changes are following guidelines in #1610.
AddAppServiceResourceDetector
,AddAzureVMResourceDetector
, andAddAzureContainerAppsResourceDetector
extension methods forResourceBuilder
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes