Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resources.Azure] Rename Azure detector namespace #1840

Merged
merged 9 commits into from
May 27, 2024

Conversation

matt-hensley
Copy link
Contributor

Changes

Changes are following guidelines in #1610.

  • Renames OpenTelemetry.ResourceDetectors.Azure to OpenTelemetry.Resources.Azure
  • Makes detectors internal
  • Adds AddAppServiceResourceDetector, AddAzureVMResourceDetector, and AddAzureContainerAppsResourceDetector extension methods for ResourceBuilder

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 72.31%. Comparing base (71655ce) to head (7faf0b0).
Report is 275 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1840      +/-   ##
==========================================
- Coverage   73.91%   72.31%   -1.60%     
==========================================
  Files         267      300      +33     
  Lines        9615    11491    +1876     
==========================================
+ Hits         7107     8310    +1203     
- Misses       2508     3181     +673     
Flag Coverage Δ
unittests-Exporter.Geneva 52.08% <ø> (?)
unittests-Exporter.InfluxDB 95.88% <ø> (?)
unittests-Exporter.Instana 68.22% <ø> (?)
unittests-Exporter.OneCollector 89.46% <ø> (?)
unittests-Exporter.Stackdriver 75.73% <ø> (?)
unittests-Extensions 79.33% <ø> (?)
unittests-Extensions.AWS 83.41% <ø> (?)
unittests-Extensions.Enrichment 100.00% <ø> (?)
unittests-Instrumentation.AWS 87.37% <ø> (?)
unittests-Instrumentation.AWSLambda 87.96% <ø> (?)
unittests-Instrumentation.AspNet 74.85% <ø> (?)
unittests-Instrumentation.AspNetCore 85.27% <ø> (?)
unittests-Instrumentation.ElasticsearchClient 79.87% <ø> (?)
unittests-Instrumentation.EntityFrameworkCore 55.49% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcNetClient 79.61% <ø> (?)
unittests-Instrumentation.Hangfire 93.58% <ø> (?)
unittests-Instrumentation.Http 81.79% <ø> (?)
unittests-Instrumentation.Owin 83.43% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Quartz 78.94% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.SqlClient 91.89% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 68.02% <ø> (?)
unittests-Instrumentation.Wcf 78.47% <ø> (?)
unittests-PersistentStorage 65.44% <ø> (?)
unittests-ResourceDetectors.AWS 79.02% <ø> (?)
unittests-ResourceDetectors.Container 75.00% <ø> (?)
unittests-Resources.Azure 77.94% <0.00%> (?)
unittests-Resources.Gcp 72.54% <ø> (?)
unittests-Resources.Host 52.87% <ø> (?)
unittests-Resources.Process 81.81% <ø> (?)
unittests-Resources.ProcessRuntime 72.91% <ø> (?)
unittests-Sampler.AWS 87.97% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...etry.Resources.Azure/AppServiceResourceDetector.cs 88.23% <ø> (ø)
...ources.Azure/AzureContainerAppsResourceDetector.cs 85.00% <ø> (ø)
...lemetry.Resources.Azure/AzureVMResourceDetector.cs 78.12% <ø> (ø)
...emetry.Resources.Azure/AzureVmMetaDataRequestor.cs 11.11% <ø> (ø)
...lemetry.Resources.Azure/AzureVmMetadataResponse.cs 94.28% <ø> (ø)
....Resources.Azure/AzureResourceBuilderExtensions.cs 0.00% <0.00%> (ø)

... and 292 files with indirect coverage changes

@matt-hensley matt-hensley marked this pull request as ready for review May 23, 2024 20:40
@matt-hensley matt-hensley requested a review from a team May 23, 2024 20:40
@@ -2,6 +2,19 @@

## Unreleased

* **Breaking Change**: Renamed package from `OpenTelemetry.ResourceDetectors.Azure`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 very nicely written changelog.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

@Kielek Kielek added the comp:resources.azure Things related to OpenTelemetry.Resources.Azure label May 27, 2024
@Kielek Kielek merged commit f1ec716 into open-telemetry:main May 27, 2024
264 checks passed
@matt-hensley matt-hensley deleted the rename-azure-detector branch July 16, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:resources.azure Things related to OpenTelemetry.Resources.Azure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants