-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Resources.AWS] Rename AWS detector namespace #1839
[Resources.AWS] Rename AWS detector namespace #1839
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Changelog entries for breaking change advisory is very clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joegoldman2, could you please resolve conflicts after merging similar PR for Azure?
One small fix to make the codecov badge working after renames.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @ppittle could you please review it?
Contributes to #1610.
Changes
AddAWSEBSDetector
,AddAWSEC2Detector
,AddAWSECSDetector
andAddAWSEKSDetector
extension methods for ResourceBuilderFor significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes