Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resources.AWS] Rename AWS detector namespace #1839

Merged
merged 10 commits into from
May 30, 2024

Conversation

joegoldman2
Copy link
Contributor

@joegoldman2 joegoldman2 commented May 23, 2024

Contributes to #1610.

Changes

  • Renames OpenTelemetry.ResourceDetectors.AWS to OpenTelemetry.Resources.AWS
  • Makes detectors internal
  • Adds AddAWSEBSDetector, AddAWSEC2Detector, AddAWSECSDetector and AddAWSEKSDetector extension methods for ResourceBuilder

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 21.05263% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 70.09%. Comparing base (71655ce) to head (ab3d45e).
Report is 279 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1839      +/-   ##
==========================================
- Coverage   73.91%   70.09%   -3.82%     
==========================================
  Files         267      295      +28     
  Lines        9615    10825    +1210     
==========================================
+ Hits         7107     7588     +481     
- Misses       2508     3237     +729     
Flag Coverage Δ
unittests-Exporter.Geneva 52.08% <ø> (?)
unittests-Exporter.InfluxDB 94.65% <ø> (?)
unittests-Exporter.Instana 68.22% <ø> (?)
unittests-Exporter.OneCollector 89.72% <ø> (?)
unittests-Exporter.Stackdriver 75.73% <ø> (?)
unittests-Extensions 79.33% <ø> (?)
unittests-Extensions.AWS 83.41% <ø> (?)
unittests-Extensions.Enrichment 100.00% <ø> (?)
unittests-Instrumentation.AWS 80.30% <ø> (?)
unittests-Instrumentation.AWSLambda 87.96% <ø> (?)
unittests-Instrumentation.AspNet 74.55% <ø> (?)
unittests-Instrumentation.AspNetCore 85.27% <ø> (?)
unittests-Instrumentation.ElasticsearchClient 79.87% <ø> (?)
unittests-Instrumentation.EntityFrameworkCore 55.49% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcNetClient 79.61% <ø> (?)
unittests-Instrumentation.Hangfire 93.58% <ø> (?)
unittests-Instrumentation.Http 81.08% <ø> (?)
unittests-Instrumentation.Owin 83.43% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Quartz 78.94% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.SqlClient 91.89% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 68.02% <ø> (?)
unittests-Instrumentation.Wcf 48.91% <ø> (?)
unittests-PersistentStorage 65.78% <ø> (?)
unittests-ResourceDetectors.Container 75.00% <ø> (?)
unittests-Resources.AWS 76.02% <21.05%> (?)
unittests-Resources.Azure 78.35% <ø> (?)
unittests-Resources.Gcp 72.54% <ø> (?)
unittests-Resources.Host 52.87% <ø> (?)
unittests-Resources.Process 81.81% <ø> (?)
unittests-Resources.ProcessRuntime 82.35% <ø> (?)
unittests-Sampler.AWS 87.97% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/OpenTelemetry.Resources.AWS/AWSEBSDetector.cs 92.00% <100.00%> (ø)
src/OpenTelemetry.Resources.AWS/AWSEC2Detector.cs 73.52% <100.00%> (ø)
...Telemetry.Resources.AWS/AWSResourcesEventSource.cs 35.71% <ø> (ø)
...emetry.Resources.AWS/Models/AWSEBSMetadataModel.cs 100.00% <ø> (ø)
...esources.AWS/Models/AWSEC2IdentityDocumentModel.cs 100.00% <ø> (ø)
...try.Resources.AWS/Models/AWSEKSClusterDataModel.cs 100.00% <ø> (ø)
...ources.AWS/Models/AWSEKSClusterInformationModel.cs 100.00% <ø> (ø)
...enTelemetry.Resources.AWS/ResourceDetectorUtils.cs 100.00% <ø> (ø)
src/OpenTelemetry.Resources.AWS/AWSEKSDetector.cs 58.62% <25.00%> (ø)
src/OpenTelemetry.Resources.AWS/AWSECSDetector.cs 88.00% <20.00%> (ø)
... and 1 more

... and 292 files with indirect coverage changes

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Changelog entries for breaking change advisory is very clear.

@Kielek Kielek added the comp:resources.aws Things related to OpenTelemetry.Resources.AWS label May 27, 2024
Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joegoldman2, could you please resolve conflicts after merging similar PR for Azure?

One small fix to make the codecov badge working after renames.

src/OpenTelemetry.Resources.AWS/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @ppittle could you please review it?

@Kielek Kielek merged commit 47b667a into open-telemetry:main May 30, 2024
264 of 265 checks passed
@joegoldman2 joegoldman2 deleted the rename-resources-aws branch May 30, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:resources.aws Things related to OpenTelemetry.Resources.AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants