Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Microsoft.Extensions.Options version to 8.0.0 #1830

Merged

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented May 22, 2024

Fixes #1683.

Changes

Unify Microsoft.Extensions.Options version to 8.0.0.
This package version is used on OpenTelemetry package.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #
  • [ ] Changes in public API reviewed

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.37%. Comparing base (71655ce) to head (8335d0d).
Report is 278 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1830      +/-   ##
==========================================
- Coverage   73.91%   70.37%   -3.54%     
==========================================
  Files         267      294      +27     
  Lines        9615    10829    +1214     
==========================================
+ Hits         7107     7621     +514     
- Misses       2508     3208     +700     
Flag Coverage Δ
unittests-Exporter.InfluxDB 94.65% <ø> (?)
unittests-Exporter.Instana 68.22% <ø> (?)
unittests-Exporter.Stackdriver 75.73% <ø> (?)
unittests-Extensions 79.83% <ø> (?)
unittests-Extensions.AWS 77.24% <ø> (?)
unittests-Extensions.Enrichment 100.00% <ø> (?)
unittests-Instrumentation.AWS 80.30% <ø> (?)
unittests-Instrumentation.AWSLambda 87.96% <ø> (?)
unittests-Instrumentation.ElasticsearchClient 79.87% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 291 files with indirect coverage changes

@Kielek Kielek marked this pull request as ready for review May 22, 2024 06:34
@Kielek Kielek requested a review from a team May 22, 2024 06:34
@Kielek Kielek added infra Infra work - CI/CD, code coverage, linters comp:instrumentation.hangfire Things related to OpenTelemetry.Instrumentation.Hangfire comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis labels May 22, 2024
@vishweshbankwar vishweshbankwar merged commit e1c31d0 into open-telemetry:main May 29, 2024
264 of 265 checks passed
@Kielek Kielek deleted the unify-microsoft-extenstions-options branch May 29, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore comp:instrumentation.hangfire Things related to OpenTelemetry.Instrumentation.Hangfire comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify Microsoft.Extensions.Options package version across repository
7 participants