Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.AspNet] Improve enrich methods #1824

Merged
merged 5 commits into from
May 21, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented May 21, 2024

Fixes #766

Changes

Instrumentation.AspNet - Improve enrich methods. It propagates what we have in stable AspNetCore package.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #
  • Changes in public API reviewed

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.13%. Comparing base (71655ce) to head (ccc0819).
Report is 265 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1824      +/-   ##
==========================================
+ Coverage   73.91%   79.13%   +5.22%     
==========================================
  Files         267      115     -152     
  Lines        9615     2991    -6624     
==========================================
- Hits         7107     2367    -4740     
+ Misses       2508      624    -1884     
Flag Coverage Δ
unittests-Solution 79.13% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 258 files with indirect coverage changes

@Kielek Kielek force-pushed the aspnet-enrich-methods branch 2 times, most recently from 7bc5e2b to 7ca5797 Compare May 21, 2024 06:45
@Kielek Kielek marked this pull request as ready for review May 21, 2024 07:04
@Kielek Kielek requested a review from a team May 21, 2024 07:04
@Kielek Kielek added the comp:instrumentation.aspnet Things related to OpenTelemetry.Instrumentation.AspNet label May 21, 2024
};
o.EnrichWithException = (activity, exception) =>
{
activity.SetTag("exceptionType", exception.GetType().ToString());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to change this tag to something else, as exception.type would be already covered by the instrumentation library, following the otel semantic convention!
Not a blocker, as we need to do it (if we chose to), for other instrumentation too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created separate iisue: #1828

@Kielek Kielek merged commit 9f99266 into open-telemetry:main May 21, 2024
38 of 39 checks passed
@Kielek Kielek deleted the aspnet-enrich-methods branch May 21, 2024 19:08
@CodeBlanch
Copy link
Member

CodeBlanch commented May 21, 2024

Seems like a problem was introduced here: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/actions/runs/9180095969/job/25244103909?pr=1827#step:6:11

Interesting the ci didn't run these tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.aspnet Things related to OpenTelemetry.Instrumentation.AspNet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Enrich callbacks to use specific type for rawObject
4 participants