Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.AspNetCore, Instrumentation.Http] Revert support for OTEL_INSTRUMENTATION_HTTP_KNOWN_METHODS #1754

Merged
merged 4 commits into from
May 15, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented May 14, 2024

Related to: #1731.

Changes

[Instrumentation.AspNetCore, Instrumentation.Http] Revert support for OTEL_INSTRUMENTATION_HTTP_KNOWN_METHODS
It was introduces as a side effect of the migration to contrib repository in #1707 and #1694

For significant contributions please make sure you have completed the following items:

  • [ ] Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #
  • [ ] Changes in public API reviewed

@Kielek Kielek requested a review from a team May 14, 2024 04:40
@Kielek Kielek added comp:instrumentation.aspnetcore Things related to OpenTelemetry.Instrumentation.AspNetCore comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http labels May 14, 2024
@Kielek Kielek changed the title [Instrumentation.AspNetCore, Instrumentation.Http] Document support for OTEL_INSTRUMENTATION_HTTP_KNOWN_METHODS [Instrumentation.AspNetCore, Instrumentation.Http] Changelog - support for OTEL_INSTRUMENTATION_HTTP_KNOWN_METHODS May 14, 2024
@Kielek Kielek changed the title [Instrumentation.AspNetCore, Instrumentation.Http] Changelog - support for OTEL_INSTRUMENTATION_HTTP_KNOWN_METHODS [Instrumentation.AspNetCore, Instrumentation.Http] Rever support for OTEL_INSTRUMENTATION_HTTP_KNOWN_METHODS May 15, 2024
@Kielek Kielek changed the title [Instrumentation.AspNetCore, Instrumentation.Http] Rever support for OTEL_INSTRUMENTATION_HTTP_KNOWN_METHODS [Instrumentation.AspNetCore, Instrumentation.Http] Revert support for OTEL_INSTRUMENTATION_HTTP_KNOWN_METHODS May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.29%. Comparing base (71655ce) to head (05856a6).
Report is 240 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1754      +/-   ##
==========================================
+ Coverage   73.91%   76.29%   +2.37%     
==========================================
  Files         267      298      +31     
  Lines        9615    11622    +2007     
==========================================
+ Hits         7107     8867    +1760     
- Misses       2508     2755     +247     
Flag Coverage Δ
unittests-Exporter.Geneva 64.47% <ø> (?)
unittests-Exporter.OneCollector 89.72% <ø> (?)
unittests-Extensions 79.33% <ø> (?)
unittests-Instrumentation.AspNet 74.39% <100.00%> (?)
unittests-Instrumentation.AspNetCore 85.27% <100.00%> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcNetClient 78.78% <ø> (?)
unittests-Instrumentation.Http 81.91% <100.00%> (?)
unittests-Instrumentation.Owin 83.43% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.SqlClient 90.90% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 71.00% <ø> (?)
unittests-Instrumentation.Wcf 78.47% <ø> (?)
unittests-PersistentStorage 65.78% <ø> (?)
unittests-ResourceDetectors.Azure 81.53% <ø> (?)
unittests-ResourceDetectors.Host 54.11% <ø> (?)
unittests-ResourceDetectors.ProcessRuntime 76.08% <ø> (?)
unittests-Resources.Gcp 72.54% <ø> (?)
unittests-Resources.Process 81.81% <ø> (?)
unittests-Solution 80.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...umentation.AspNet/Implementation/HttpInListener.cs 88.46% <100.00%> (+0.14%) ⬆️
...ion.AspNet/Implementation/HttpInMetricsListener.cs 97.36% <100.00%> (-2.64%) ⬇️
...ation.AspNetCore/Implementation/TelemetryHelper.cs 88.88% <100.00%> (ø)
...strumentation.Http/Implementation/HttpTagHelper.cs 100.00% <100.00%> (ø)

... and 279 files with indirect coverage changes

Copy link
Member

@vishweshbankwar vishweshbankwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Please update the PR description as well.

@Kielek Kielek merged commit 137e43b into open-telemetry:main May 15, 2024
153 of 154 checks passed
@Kielek Kielek deleted the document-http-known-methods branch May 15, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.aspnetcore Things related to OpenTelemetry.Instrumentation.AspNetCore comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants