-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.AspNetCore, Instrumentation.Http] Revert support for OTEL_INSTRUMENTATION_HTTP_KNOWN_METHODS #1754
[Instrumentation.AspNetCore, Instrumentation.Http] Revert support for OTEL_INSTRUMENTATION_HTTP_KNOWN_METHODS #1754
Conversation
…or OTEL_INSTRUMENTATION_HTTP_KNOWN_METHODS
…ODS in Http and AspNetCore instrumentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1754 +/- ##
==========================================
+ Coverage 73.91% 76.29% +2.37%
==========================================
Files 267 298 +31
Lines 9615 11622 +2007
==========================================
+ Hits 7107 8867 +1760
- Misses 2508 2755 +247 Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: Please update the PR description as well.
Related to: #1731.
Changes
[Instrumentation.AspNetCore, Instrumentation.Http] Revert support for OTEL_INSTRUMENTATION_HTTP_KNOWN_METHODS
It was introduces as a side effect of the migration to contrib repository in #1707 and #1694
For significant contributions please make sure you have completed the following items:
[ ] AppropriateCHANGELOG.md
updated for non-trivial changes[ ] Design discussion issue #[ ] Changes in public API reviewed