Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.AspNet][Instrumentation.Owin] Redact query parameters #1656

Merged
merged 9 commits into from
Apr 17, 2024

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Apr 17, 2024

Fixes #.

Changes

Propagating changes from open-telemetry/opentelemetry-dotnet#5532

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 62.16216% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 73.87%. Comparing base (71655ce) to head (eab54b7).
Report is 188 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1656      +/-   ##
==========================================
- Coverage   73.91%   73.87%   -0.05%     
==========================================
  Files         267      263       -4     
  Lines        9615     9920     +305     
==========================================
+ Hits         7107     7328     +221     
- Misses       2508     2592      +84     
Flag Coverage Δ
unittests-Exporter.Geneva 60.42% <ø> (?)
unittests-Exporter.OneCollector 89.72% <ø> (?)
unittests-Extensions 82.75% <ø> (?)
unittests-Instrumentation.AspNet 76.83% <64.70%> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.Owin 83.43% <60.00%> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 71.00% <ø> (?)
unittests-Instrumentation.Wcf 78.47% <ø> (?)
unittests-PersistentStorage 65.78% <ø> (?)
unittests-ResourceDetectors.Azure 81.53% <ø> (?)
unittests-ResourceDetectors.Host 54.11% <ø> (?)
unittests-ResourceDetectors.Process 100.00% <ø> (?)
unittests-ResourceDetectors.ProcessRuntime 76.08% <ø> (?)
unittests-Solution 79.45% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...umentation.AspNet/Implementation/HttpInListener.cs 88.60% <100.00%> (+0.29%) ⬆️
...ation.Owin/Implementation/DiagnosticsMiddleware.cs 90.47% <100.00%> (-1.39%) ⬇️
...tation.AspNet/AspNetTraceInstrumentationOptions.cs 76.92% <70.00%> (ø)
...Implementation/AspNetInstrumentationEventSource.cs 77.77% <40.00%> (+0.85%) ⬆️
...Instrumentation.Owin/OwinInstrumentationOptions.cs 76.92% <70.00%> (-23.08%) ⬇️
...n/Implementation/OwinInstrumentationEventSource.cs 27.77% <0.00%> (-10.69%) ⬇️

... and 203 files with indirect coverage changes

@CodeBlanch CodeBlanch added comp:instrumentation.owin Things related to OpenTelemetry.Instrumentation.Owin comp:instrumentation.aspnet Things related to OpenTelemetry.Instrumentation.AspNet labels Apr 17, 2024
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishweshbankwar vishweshbankwar marked this pull request as ready for review April 17, 2024 18:46
@vishweshbankwar vishweshbankwar requested a review from a team April 17, 2024 18:46
@vishweshbankwar vishweshbankwar merged commit 113e5b8 into open-telemetry:main Apr 17, 2024
112 of 114 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.aspnet Things related to OpenTelemetry.Instrumentation.AspNet comp:instrumentation.owin Things related to OpenTelemetry.Instrumentation.Owin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants