-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ResourceDetector.Host] Add host.id for non-containerized systems #1631
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1631 +/- ##
===========================================
- Coverage 73.91% 54.11% -19.80%
===========================================
Files 267 2 -265
Lines 9615 85 -9530
===========================================
- Hits 7107 46 -7061
+ Misses 2508 39 -2469
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please extend also README and CHANGELOG.
Good to see this PR!
2d77f4d
to
7b4f7a1
Compare
Please fix compilation/linting issues. |
a74de39
to
84b97ee
Compare
62c6376
to
d464f89
Compare
Co-authored-by: Piotr Kiełkowicz <[email protected]>
Fixes #1630
Changes
Adds support for setting
host.id
on Linux, MacOS, and Windows when running outside a container.CHANGELOG.md
updated for non-trivial changes