Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResourceDetector.Host] Add host.id for non-containerized systems #1631

Merged
merged 25 commits into from
Apr 12, 2024

Conversation

matt-hensley
Copy link
Contributor

Fixes #1630

Changes

Adds support for setting host.id on Linux, MacOS, and Windows when running outside a container.

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@github-actions github-actions bot requested review from Kielek and lachmatt March 28, 2024 15:29
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 54.11%. Comparing base (71655ce) to head (b6444be).
Report is 183 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1631       +/-   ##
===========================================
- Coverage   73.91%   54.11%   -19.80%     
===========================================
  Files         267        2      -265     
  Lines        9615       85     -9530     
===========================================
- Hits         7107       46     -7061     
+ Misses       2508       39     -2469     
Flag Coverage Δ
unittests-ResourceDetectors.Host 54.11% <58.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...enTelemetry.ResourceDetectors.Host/HostDetector.cs 56.96% <58.33%> (ø)

... and 263 files with indirect coverage changes

Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please extend also README and CHANGELOG.

Good to see this PR!

src/OpenTelemetry.ResourceDetectors.Host/HostDetector.cs Outdated Show resolved Hide resolved
src/OpenTelemetry.ResourceDetectors.Host/HostDetector.cs Outdated Show resolved Hide resolved
src/OpenTelemetry.ResourceDetectors.Host/HostDetector.cs Outdated Show resolved Hide resolved
src/OpenTelemetry.ResourceDetectors.Host/HostDetector.cs Outdated Show resolved Hide resolved
@Kielek Kielek added the comp:resources.host Things related to OpenTelemetry.Resources.Host label Mar 29, 2024
@matt-hensley matt-hensley marked this pull request as ready for review March 29, 2024 16:05
@matt-hensley matt-hensley requested review from a team and Kielek March 29, 2024 16:05
@Kielek
Copy link
Contributor

Kielek commented Apr 2, 2024

Please fix compilation/linting issues.

@Kielek Kielek changed the title Add host.id for non-containerized systems [ResourceDetector.Host] Add host.id for non-containerized systems Apr 10, 2024
@matt-hensley matt-hensley requested a review from lachmatt April 10, 2024 15:23
@Kielek Kielek merged commit 44c8576 into open-telemetry:main Apr 12, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:resources.host Things related to OpenTelemetry.Resources.Host
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add host.id for non-containerized systems
3 participants