-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ResourceDetectors.AWS] Implement support for some cloud.* attributes in AWS ECS detector #1552
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1552 +/- ##
==========================================
+ Coverage 73.91% 80.66% +6.75%
==========================================
Files 267 113 -154
Lines 9615 3083 -6532
==========================================
- Hits 7107 2487 -4620
+ Misses 2508 596 -1912
Flags with carried forward coverage won't be shown. Click here to find out more.
|
f66b4bb
to
60fb095
Compare
…ability_zone,region} in AWS ECS detector Implement support for the following resource attributes in the AWS ECS detector when using the metadata endpoint v4: * cloud.account.id * cloud.availability_zone * cloud.region Also, fix mispelling of the AWSSemanticConventions.AttributeCloudAvailableZone to AWSSemanticConventions.AttributeCloudAvailabilityZone
60fb095
to
e0da1f0
Compare
The build error looks like something that is on
|
@ppittle, @normj, @birojnayak, please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.. thank you for adding additional details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@mmanciop, please update also README.md. There is a list of detected resource. |
Done in 4ead9fd, and I retrofitted the update I forgot back when with #875. Although I gotta say, this format that does not neither mentions the actual keys, nor links to the specs of the semconvs, does not strike me as particularly useful. |
Other documentation relays on exact keys: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/src/OpenTelemetry.ResourceDetectors.ProcessRuntime/README.md It can be fixed as separate PR. Merging. |
Changes
Implement support for the following resource attributes in the AWS ECS detector when using the metadata endpoint v4:
Also, fix mispelling of the AWSSemanticConventions.AttributeCloudAvailableZone to AWSSemanticConventions.AttributeCloudAvailabilityZone
CHANGELOG.md
updated for non-trivial changes