Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OneCollectorExporter] Add LogRecord.Body support #1321

Merged

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Aug 24, 2023

Changes

  • Adds support for LogRecord.Body if {OriginalFormat} key is not found
  • Adds support for sending formatted message if it is present and differs from the body

TODOs

  • Appropriate CHANGELOG.md updated for non-trivial changes

@CodeBlanch CodeBlanch requested a review from a team August 24, 2023 23:18
@github-actions github-actions bot requested a review from reyang August 24, 2023 23:18
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #1321 (82fd577) into main (fc4dc0d) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1321      +/-   ##
==========================================
+ Coverage   74.53%   74.57%   +0.03%     
==========================================
  Files         262      262              
  Lines        9524     9537      +13     
==========================================
+ Hits         7099     7112      +13     
  Misses       2425     2425              
Files Changed Coverage Δ
...rialization/LogRecordCommonSchemaJsonSerializer.cs 99.18% <100.00%> (+0.09%) ⬆️

@utpilla utpilla added the comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector label Aug 25, 2023
@CodeBlanch CodeBlanch merged commit e0ea358 into open-telemetry:main Aug 25, 2023
20 of 21 checks passed
@CodeBlanch CodeBlanch deleted the onecollector-logrecord-body branch August 25, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants