Rename package: [OpenTelemetry.Contrib.Instrumentation.AWS] to [OpenTelemetry.Instrumentation.AWS] #1275
Conversation
….Instrumentation.AWS]
|
I just noticed that the AWS packages are also the only ones that break the capitalization rule at https://learn.microsoft.com/en-us/dotnet/standard/design-guidelines/capitalization-conventions#capitalization-rules-for-identifiers which states that for acronyms longer than two letters, only the first one should be uppercased. So the namespace & package name ought to be Aws instead of AWS. |
src/OpenTelemetry.Instrumentation.AWS/Implementation/AWSTracingPipelineHandler.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Instrumentation.AWS/OpenTelemetry.Instrumentation.AWS.csproj
Outdated
Show resolved
Hide resolved
utpilla
added
the
comp:instrumentation.aws
test/OpenTelemetry.Instrumentation.AWS.Tests/OpenTelemetry.Instrumentation.AWS.Tests.csproj
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Instrumentation.AWS/TracerProviderBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
I think it's a subject of different PR where we should include AWSLambda package too. The current renaming follows initial rules introduced in AWS projects. |
…elemetry.Instrumentation.AWS]: removed redundant project file
…elemetry.Instrumentation.AWS]: - inverted changes introduced by auto-refactoring (only renaming related changes should be kept) - keep the namespace name for TracerProviderBuilderExtensions
…elemetry.Instrumentation.AWS]: reverted one more line appeared after auto-refactoring
…elemetry.Instrumentation.AWS]: updated CHANGELOG
…elemetry.Instrumentation.AWS]: moved the latest unreleased change record to the top
…elemetry.Instrumentation.AWS]: added point and removed white space
….com/rypdal/opentelemetry-dotnet-contrib into feature/instrumentation-aws-renaming
|
Seems failed tests appeared after the merge from main. |
|
As soon as we find a way to fix this step: Build / build-test (windows-latest, net462) (pull_request). In general it is passing in different PRs. |
|
Merging per comment #875 (comment) |
Name of the package OpenTelemetry.Contrib.Instrumentation.AWS is not consistent with current naming conventions and
Contribsuffix should be removed.Package project and all related artefacts like namespaces, etc should be changed to OpenTelemetry.Instrumentation.AWS
This PR is the result of discussions in the other PR: #1224 (comment)