Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter.Geneva] Update OTel SDK version to 1.5.0 and remove Exemplars support #1238

Merged

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Jun 14, 2023

Changes

  • Update OTel SDK version to 1.5.0
  • Remove Exemplars support

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes

@utpilla utpilla added the comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva label Jun 14, 2023
@utpilla utpilla requested a review from a team June 14, 2023 22:27
@utpilla utpilla changed the title [Exporter.Geneva] Update OTel SDK version to 1.5.0 and Mark Exemplars internal [Exporter.Geneva] Update OTel SDK version to 1.5.0 and remove Exemplars support Jun 14, 2023
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #1238 (e551255) into main (dbfeaea) will decrease coverage by 0.65%.
The diff coverage is n/a.

❗ Current head e551255 differs from pull request most recent head 1008d5c. Consider uploading reports for the commit 1008d5c to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1238      +/-   ##
==========================================
- Coverage   73.61%   72.97%   -0.65%     
==========================================
  Files         265      265              
  Lines        9346     9279      -67     
==========================================
- Hits         6880     6771     -109     
- Misses       2466     2508      +42     
Impacted Files Coverage Δ
...ry.Exporter.Geneva/Metrics/GenevaMetricExporter.cs 70.03% <ø> (-4.52%) ⬇️

... and 1 file with indirect coverage changes

@utpilla utpilla merged commit d3d9ab4 into open-telemetry:main Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants