Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[redis] Append options name to the background thread #1205

Merged
merged 3 commits into from
May 25, 2023
Merged

[redis] Append options name to the background thread #1205

merged 3 commits into from
May 25, 2023

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented May 24, 2023 •
edited by Kielek
Loading

Following up on #1193 (comment)

Changes

  • Append the name of the options (when used) to the background thread responsible for draining Redis profiling sessions.

TODOs

  • Appropriate CHANGELOG.md updated for non-trivial changes

@CodeBlanch CodeBlanch requested a review from a team May 24, 2023 17:33
@CodeBlanch
Copy link
Member Author

@utpilla Following up on conversation (#1193 (comment)).

  • I couldn't move the background thread up a level because the individual options have their own configurable flush interval ☹️
  • I used the options name because I couldn't find anything else useful to put on the thread name 🤣

@utpilla utpilla added the comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis label May 24, 2023
Havret
Havret approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@Havret Havret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Kielek @utpilla
Fix link in changelog
64fb0b8 
Co-authored-by: Utkarsh Umesan Pillai <[email protected]>
@Kielek Kielek merged commit e1a9340 into open-telemetry:main May 25, 2023
@CodeBlanch CodeBlanch deleted the redis-threadname branch May 25, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utpilla utpilla utpilla approved these changes

@Havret Havret Havret approved these changes

@Kielek Kielek Kielek approved these changes

Assignees
No one assigned
Labels
comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CodeBlanch @Kielek @Havret @utpilla