-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.EntityFrameworkCore] Add Filter public API to enable filtering #1203
Conversation
Did you considered using |
Yes, we can modify activity with |
@akoken, I have checked it internally with other maintainers. Please consider following The string parameter could be potentially providerName. EDIT: markdown list is failing - probably to long lines. |
@Kielek, I added |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1203 +/- ##
==========================================
- Coverage 73.61% 72.93% -0.68%
==========================================
Files 265 265
Lines 9346 9301 -45
==========================================
- Hits 6880 6784 -96
- Misses 2466 2517 +51
|
src/OpenTelemetry.Instrumentation.EntityFrameworkCore/EntityFrameworkInstrumentationOptions.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Utkarsh Umesan Pillai <[email protected]>
Changes
This PR introduces the addition of a
Filter
public API, which enables filtering out activities based on the properties of theIDbCommand
object being executed. TheFilter
API provides users with the ability to apply custom filters to only collect specific activities, enhancing the flexibility and versatility of the system.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes