[redis] Modernize the StackExchangeRedis project #1183
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1183 +/- ##
==========================================
- Coverage 72.88% 72.82% -0.07%
==========================================
Files 247 247
Lines 8852 8836 -16
==========================================
- Hits 6452 6435 -17
- Misses 2400 2401 +1
|
utpilla
added
the
comp:instrumentation.stackexchangeredis
| /// </remarks> | ||
| /// <param name="builder"><see cref="TracerProviderBuilder"/> being configured.</param> | ||
| /// <returns>The instance of <see cref="TracerProviderBuilder"/> to chain the calls.</returns> | ||
| public static TracerProviderBuilder AddRedisInstrumentation( |
There was a problem hiding this comment.
These overloads are a breaking change. An update from 9.8 to latest caused a more specific overload to be called which threw an argument null exception:
b.AddRedisInstrumentation(null, c => {
c.EnrichActivityWithTimingEvents = false;
c.SetVerboseDatabaseStatements = config.FullDetails;
});```
There was a problem hiding this comment.
Sorry about that @niemyjski! It is a prerelease project so we reserve the right to make breaking changes until it goes stable. We try not to do that, but the overloads being added here are more or less the standard ones across the instrumentation from the core repo and much of contrib so it felt needed.
If you switch to...
b.AddRedisInstrumentation(c => {
c.EnrichActivityWithTimingEvents = false;
c.SetVerboseDatabaseStatements = config.FullDetails;
});...does that work for you?
There was a problem hiding this comment.
Yes, I found that fix and left the comment above. I just wanted to bring it to attention as it wasn't in the release notes as a breaking change. Thanks again!
Changes
OpenTelemetry.Api.ProviderBuilderExtensionsand update to the latest DI patterns (adds named options support and registers the configuration delegate (if supplied) into Options API).TODOs
CHANGELOG.mdupdated for non-trivial changes