Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OneCollectorExporter] eventId support #1127

Merged
merged 4 commits into from
Apr 3, 2023
Merged

[OneCollectorExporter] eventId support #1127

merged 4 commits into from
Apr 3, 2023

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Apr 3, 2023 •
edited
Loading

Changes

  • Adds support for the eventId field which was recently defined in common schema.

TODOs

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Unit tests

@CodeBlanch CodeBlanch added the comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector label Apr 3, 2023
@CodeBlanch CodeBlanch requested a review from a team April 3, 2023 17:03
@github-actions github-actions bot requested a review from reyang April 3, 2023 17:03
@Kielek Kielek merged commit af46ef2 into open-telemetry:main Apr 3, 2023
@CodeBlanch CodeBlanch deleted the onecollector-eventId-support branch April 3, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utpilla utpilla utpilla approved these changes

@reyang reyang reyang approved these changes

@Kielek Kielek Kielek approved these changes

Assignees

@reyang reyang

@CodeBlanch CodeBlanch

Labels
comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CodeBlanch @Kielek @reyang @utpilla