Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.AWS] drop default parameter from registration method #1117

Merged
merged 3 commits into from
Apr 1, 2023

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Mar 29, 2023

Fixes #.

Changes

[Instrumentation.AWS] drop default parameter from registration method
There will be no compilation time changes, what is more, the next release should rename the package. It is good moment to change API.

Similar PR for AWSLamda with explanations: #943

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #
  • Changes in public API reviewed

@Kielek Kielek added the comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS label Mar 29, 2023
@github-actions github-actions bot requested a review from srprash March 29, 2023 07:07
@Kielek Kielek force-pushed the i-aws-remove-default-parameter branch from a31ef32 to 453a348 Compare March 29, 2023 07:07
@Kielek Kielek marked this pull request as ready for review March 30, 2023 13:16
@Kielek Kielek requested review from a team March 30, 2023 13:16
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #1117 (74743f5) into main (d99d1d3) will increase coverage by 0.01%.
The diff coverage is 78.94%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1117      +/-   ##
==========================================
+ Coverage   71.25%   71.27%   +0.01%     
==========================================
  Files         229      229              
  Lines        8493     8536      +43     
==========================================
+ Hits         6052     6084      +32     
- Misses       2441     2452      +11     
Impacted Files Coverage Δ
...ry.Exporter.Geneva/TLDExporter/TldTraceExporter.cs 32.31% <0.00%> (ø)
...ceDetectors.Container/ContainerResourceDetector.cs 82.60% <40.00%> (ø)
...ry.Exporter.Geneva/Metrics/GenevaMetricExporter.cs 80.00% <80.48%> (-0.57%) ⬇️
...rumentation.AWS/TracerProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
...rter.Geneva/Metrics/GenevaMetricExporterOptions.cs 100.00% <100.00%> (ø)
...ectors.Container/ContainerExtensionsEventSource.cs 8.33% <100.00%> (ø)
...ResourceDetectors.Container/Utils/EncodingUtils.cs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@srprash srprash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utpilla utpilla merged commit 11c69f1 into open-telemetry:main Apr 1, 2023
@Kielek Kielek deleted the i-aws-remove-default-parameter branch April 1, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants