Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter.Geneva] Add support for exporting metrics to different combinations of account and namespace #1111

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Mar 28, 2023

Users can now export individual metric streams to:

  • An account of their choice by adding the dimension _microsoft_metrics_account and providing a string value for it as the account name.
  • A metric namespace of their choice by adding the dimension _microsoft_metrics_namespace and providing a string value for it as the namespace name.

Note: This is not required. By default, the metrics would be sent to the account/namespace values provided in the ConnectionString. This feature allows you to override this behavior selectively by adding these custom tags only to those metrics that you would like to send to some custom account/namespace different from the default ones (coming from the ConnectionString).

Changes

  • Add support for exporting metrics to different combinations of account and namespace

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes

@utpilla utpilla added the comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva label Mar 28, 2023
@utpilla utpilla requested a review from a team March 28, 2023 02:13
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #1111 (591cc63) into main (d99d1d3) will increase coverage by 0.01%.
The diff coverage is 81.17%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1111      +/-   ##
==========================================
+ Coverage   71.25%   71.27%   +0.01%     
==========================================
  Files         229      229              
  Lines        8493     8535      +42     
==========================================
+ Hits         6052     6083      +31     
- Misses       2441     2452      +11     
Impacted Files Coverage Δ
...ry.Exporter.Geneva/Metrics/GenevaMetricExporter.cs 80.00% <80.48%> (-0.57%) ⬇️
...rter.Geneva/Metrics/GenevaMetricExporterOptions.cs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants