-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Exporter.Geneva] Add support for exporting metrics to different combinations of account and namespace #1111
Merged
utpilla
merged 7 commits into
open-telemetry:main
from
utpilla:utpilla/Add-support-for-multiple-account-namespace
Mar 29, 2023
Merged
[Exporter.Geneva] Add support for exporting metrics to different combinations of account and namespace #1111
utpilla
merged 7 commits into
open-telemetry:main
from
utpilla:utpilla/Add-support-for-multiple-account-namespace
Mar 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utpilla
added
the
comp:exporter.geneva
Things related to OpenTelemetry.Exporter.Geneva
label
Mar 28, 2023
github-actions
bot
assigned cijothomas, CodeBlanch, mic-max, reyang, utpilla and Yun-Ting
Mar 28, 2023
github-actions
bot
requested review from
cijothomas,
CodeBlanch,
mic-max,
reyang and
Yun-Ting
March 28, 2023 02:13
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1111 +/- ##
==========================================
+ Coverage 71.25% 71.27% +0.01%
==========================================
Files 229 229
Lines 8493 8535 +42
==========================================
+ Hits 6052 6083 +31
- Misses 2441 2452 +11
|
cijothomas
reviewed
Mar 28, 2023
cijothomas
reviewed
Mar 28, 2023
cijothomas
reviewed
Mar 28, 2023
cijothomas
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ttps://github.com/utpilla/opentelemetry-dotnet-contrib into utpilla/Add-support-for-multiple-account-namespace
cijothomas
approved these changes
Mar 29, 2023
1 task
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can now export individual metric streams to:
_microsoft_metrics_account
and providing astring
value for it as the account name._microsoft_metrics_namespace
and providing astring
value for it as the namespace name.Note: This is not required. By default, the metrics would be sent to the account/namespace values provided in the ConnectionString. This feature allows you to override this behavior selectively by adding these custom tags only to those metrics that you would like to send to some custom account/namespace different from the default ones (coming from the ConnectionString).
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes