Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OneCollector] Support common schema exception extension #1082

Merged

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Mar 15, 2023

Changes

  • Added support for sending ex (Exception) extension when LogRecord.Exception is specified.

TODOs

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Unit tests
  • Changes in public API reviewed

@CodeBlanch CodeBlanch added the comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector label Mar 15, 2023
@CodeBlanch CodeBlanch requested a review from a team March 15, 2023 19:51
@github-actions github-actions bot requested a review from reyang March 15, 2023 19:51
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@fa26ec8). Click here to learn what that means.
The diff coverage is 51.41%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1082   +/-   ##
=======================================
  Coverage        ?   69.38%           
=======================================
  Files           ?      214           
  Lines           ?     8358           
  Branches        ?        0           
=======================================
  Hits            ?     5799           
  Misses          ?     2559           
  Partials        ?        0           
Impacted Files Coverage Δ
...emetry.Exporter.Geneva/Metrics/MetricSerializer.cs 42.30% <0.00%> (ø)
...Geneva/Metrics/Transport/MetricEtwDataTransport.cs 69.23% <0.00%> (ø)
...porter.OneCollector/OneCollectorExporterOptions.cs 100.00% <ø> (ø)
...y.PersistentStorage.Abstractions/PersistentBlob.cs 52.38% <ø> (ø)
...tentStorage.Abstractions/PersistentBlobProvider.cs 26.08% <ø> (ø)
...ctions/PersistentStorageAbstractionsEventSource.cs 25.00% <ø> (ø)
...Telemetry.PersistentStorage.FileSystem/FileBlob.cs 75.55% <ø> (ø)
...y.PersistentStorage.FileSystem/FileBlobProvider.cs 77.41% <ø> (ø)
...Storage.FileSystem/PersistentStorageEventSource.cs 16.07% <ø> (ø)
...stentStorage.FileSystem/PersistentStorageHelper.cs 69.69% <ø> (ø)
... and 14 more

@CodeBlanch CodeBlanch merged commit 90e7888 into open-telemetry:main Mar 16, 2023
@CodeBlanch CodeBlanch deleted the onecollector-exceptionextension branch March 16, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants