Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OneCollector] Support common schema extensions in json #1073

Merged

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Mar 13, 2023

Changes

  • Adds support for sending common schema extensions in json serialization
  • Adds support for sending dt (Distributed Tracing) extension when trace context is set on LogRecord

TODOs

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Changes in public API reviewed

@CodeBlanch CodeBlanch added the comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector label Mar 13, 2023
@CodeBlanch CodeBlanch requested a review from a team March 13, 2023 20:38
@github-actions github-actions bot requested a review from reyang March 13, 2023 20:38
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@d8ec6e0). Click here to learn what that means.
The diff coverage is 95.65%.

❗ Current head 76c22f8 differs from pull request most recent head e9aea6e. Consider uploading reports for the commit e9aea6e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1073   +/-   ##
=======================================
  Coverage        ?   70.86%           
=======================================
  Files           ?      212           
  Lines           ?     8082           
  Branches        ?        0           
=======================================
  Hits            ?     5727           
  Misses          ?     2355           
  Partials        ?        0           
Impacted Files Coverage Δ
...ternal/Serialization/CommonSchemaJsonSerializer.cs 88.88% <71.42%> (ø)
...erialization/CommonSchemaJsonSerializationState.cs 97.01% <97.01%> (ø)
...ector/Internal/ExtensionFieldInformationManager.cs 100.00% <100.00%> (ø)
...lector/Internal/OneCollectorExporterEventSource.cs 29.16% <100.00%> (ø)
...rialization/CommonSchemaJsonSerializationHelper.cs 100.00% <100.00%> (ø)
...rialization/LogRecordCommonSchemaJsonSerializer.cs 98.93% <100.00%> (ø)
...orter.OneCollector/Internal/ThreadStorageHelper.cs 100.00% <100.00%> (ø)

@CodeBlanch CodeBlanch merged commit c83fb4a into open-telemetry:main Mar 13, 2023
@CodeBlanch CodeBlanch deleted the onecollector-extension-support branch March 13, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants