Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OneCollector] Add RegisterPayloadTransmittedCallback API #1058

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Mar 1, 2023

Changes

  • Adds an API which can be used to toggle on/off invocation of a callback any time a payload is transmitted by OneCollector exporter.

  • Refactors options/builders/extensions a bit to move batch options off of the exporter options class.

TODOs

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Changes in public API reviewed

@CodeBlanch CodeBlanch added the comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector label Mar 1, 2023
@CodeBlanch CodeBlanch requested a review from a team March 1, 2023 01:09
@github-actions github-actions bot requested a review from reyang March 1, 2023 01:09
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #1058 (00651a4) into main (25632df) will increase coverage by 0.32%.
The diff coverage is 81.81%.

❗ Current head 00651a4 differs from pull request most recent head 0d56085. Consider uploading reports for the commit 0d56085 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1058      +/-   ##
==========================================
+ Coverage   69.69%   70.02%   +0.32%     
==========================================
  Files         202      203       +1     
  Lines        7699     7766      +67     
==========================================
+ Hits         5366     5438      +72     
+ Misses       2333     2328       -5     
Impacted Files Coverage Δ
...lector/Internal/OneCollectorExporterEventSource.cs 26.08% <0.00%> (-3.19%) ⬇️
...neCollector/Logs/OneCollectorLogExporterOptions.cs 75.00% <ø> (-15.91%) ⬇️
...porter.OneCollector/OneCollectorExporterOptions.cs 94.73% <0.00%> (-5.27%) ⬇️
...eCollector/OneCollectorExporterTransportOptions.cs 71.42% <ø> (-0.80%) ⬇️
...ctor/Logs/OneCollectorLogExportProcessorBuilder.cs 70.17% <70.17%> (ø)
...ector/Internal/Transports/HttpJsonPostTransport.cs 82.17% <90.00%> (+3.69%) ⬆️
...ctorExporterPayloadTransmittedCallbackArguments.cs 93.75% <93.75%> (ø)
....Exporter.OneCollector/Internal/CallbackManager.cs 95.83% <95.83%> (ø)
...ternal/Serialization/CommonSchemaJsonSerializer.cs 100.00% <100.00%> (ø)
...tor/Internal/Sinks/WriteDirectlyToTransportSink.cs 91.13% <100.00%> (+0.34%) ⬆️
... and 8 more

@cijothomas cijothomas merged commit 6dc0417 into open-telemetry:main Mar 3, 2023
@CodeBlanch CodeBlanch deleted the onecollector-payloadtransmittedevent branch March 3, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants