-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OneCollector] Registration extension + tenant token tweaks #1032
[OneCollector] Registration extension + tenant token tweaks #1032
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1032 +/- ##
=======================================
Coverage ? 69.44%
=======================================
Files ? 200
Lines ? 7631
Branches ? 0
=======================================
Hits ? 5299
Misses ? 2332
Partials ? 0
|
/// <param name="instrumentationKey">Instrumentation key.</param> | ||
/// <returns>The supplied <see cref="OneCollectorLogExporterBuilder"/> for | ||
/// call chaining.</returns> | ||
public OneCollectorLogExporterBuilder SetInstrumentationKey(string instrumentationKey) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking this PR - maybe use "ConnectionString" and get rid of these domain specific concepts (as they always change).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #1037
Changes
TODOs
CHANGELOG.md
updated for non-trivial changes