Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NullReferenceException in TelemetryDispatchMessageInspector.BeforeSendReply when operation is OneWay #229

Open
ievgen-platonov opened this issue Mar 11, 2022 · 0 comments
Open

NullReferenceException in TelemetryDispatchMessageInspector.BeforeSendReply when operation is OneWay #229

ievgen-platonov opened this issue Mar 11, 2022 · 0 comments
Labels
comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf

Comments

@ievgen-platonov
Copy link
Contributor

ievgen-platonov commented Mar 11, 2022 •
edited
Loading

When a service operation is OneWay (IsOneWay = true)
then reply parameter in
BeforeSendReply(ref Message reply, object correlationState)
equals null (https://www.hummingbird-alm.com/docs/html/M_Hummingbird_TestFramework_Services_WcfMessageInspector_BeforeSendReply.htm)
that causes NullReferenceException in
reply.IsFault check

Possible solution:
Check reply object if it is not Null
then process current activity (set tags, process Enrich)
otherwise just stop activity (as it's now)

Q: Do we need to set Tag that request is OneWay (if it's possible of course)?
IevgenPlatonov added a commit to IevgenPlatonov/opentelemetry-dotnet-contrib that referenced this issue Mar 13, 2022
@IevgenPlatonov
Update TelemetryDispatchMessageInspector.cs
d931c47 
open-telemetry#229: Check if reply is not null
IevgenPlatonov added a commit to IevgenPlatonov/opentelemetry-dotnet-contrib that referenced this issue Mar 15, 2022
@IevgenPlatonov
open-telemetry#229: Added TelemetryDispatchMessageInspectorForOneWayO…
199c0aa 
…perationsTests
@ievgen-platonov ievgen-platonov mentioned this issue Mar 15, 2022
Merged
IevgenPlatonov added a commit to IevgenPlatonov/opentelemetry-dotnet-contrib that referenced this issue Mar 15, 2022
@IevgenPlatonov
open-telemetry#229: Rename parameters
5465362
IevgenPlatonov added a commit to IevgenPlatonov/opentelemetry-dotnet-contrib that referenced this issue Mar 16, 2022
@IevgenPlatonov
open-telemetry#229: Added new "1.0.0-rc6" version to CHANGELOG.md
7bd754f
IevgenPlatonov added a commit to IevgenPlatonov/opentelemetry-dotnet-contrib that referenced this issue Mar 16, 2022
@IevgenPlatonov
Merge branch 'main' into open-telemetry#229
bc3f548
IevgenPlatonov added a commit to IevgenPlatonov/opentelemetry-dotnet-contrib that referenced this issue Mar 17, 2022
@IevgenPlatonov
open-telemetry#229: Fix text formatting
7724f28
IevgenPlatonov added a commit to IevgenPlatonov/opentelemetry-dotnet-contrib that referenced this issue Mar 17, 2022
@IevgenPlatonov
open-telemetry#229: Fix CHANGELOG formatting. Added extra asserts to …
d840690 
…the test
IevgenPlatonov added a commit to IevgenPlatonov/opentelemetry-dotnet-contrib that referenced this issue Mar 17, 2022
@IevgenPlatonov
Merge branch 'open-telemetry#229' of https://github.com/iepl/opentele…
c9039f0 
…metry-dotnet-contrib into open-telemetry#229
IevgenPlatonov added a commit to IevgenPlatonov/opentelemetry-dotnet-contrib that referenced this issue Mar 17, 2022
@IevgenPlatonov
open-telemetry#229: Fix formatting
472e6af
IevgenPlatonov added a commit to IevgenPlatonov/opentelemetry-dotnet-contrib that referenced this issue Mar 17, 2022
@IevgenPlatonov
open-telemetry#229: Fix formatting in GHANGELOG.md
f864e84
IevgenPlatonov added a commit to IevgenPlatonov/opentelemetry-dotnet-contrib that referenced this issue Mar 17, 2022
@IevgenPlatonov
Merge branch 'main' into open-telemetry#229
bf4af7a
CodeBlanch pushed a commit that referenced this issue Mar 17, 2022
@ievgen-platonov @IevgenPlatonov
#229: NullReferenceException in TelemetryDispatchMessageInspector.Bef…
954b81c 
…oreSendReply when operation is OneWay (#237)

* Update TelemetryDispatchMessageInspector.cs

#229: Check if reply is not null

* #229: Added TelemetryDispatchMessageInspectorForOneWayOperationsTests

* #229: Rename parameters

* #229: Added new "1.0.0-rc6" version to CHANGELOG.md

* #229: Fix text formatting

* #229: Fix CHANGELOG formatting. Added extra asserts to the test

* #229: Fix formatting

* #229: Fix formatting in GHANGELOG.md

Co-authored-by: iepl <[email protected]>
Co-authored-by: Ievgen Platonov <[email protected]>
swetharavichandrancisco pushed a commit to swetharavichandrancisco/opentelemetry-dotnet-contrib that referenced this issue Apr 4, 2022
@ievgen-platonov @IevgenPlatonov @swetharavichandrancisco
open-telemetry#229: NullReferenceException in TelemetryDispatchMessag…
c574e42 
…eInspector.BeforeSendReply when operation is OneWay (open-telemetry#237)

* Update TelemetryDispatchMessageInspector.cs

open-telemetry#229: Check if reply is not null

* open-telemetry#229: Added TelemetryDispatchMessageInspectorForOneWayOperationsTests

* open-telemetry#229: Rename parameters

* open-telemetry#229: Added new "1.0.0-rc6" version to CHANGELOG.md

* open-telemetry#229: Fix text formatting

* open-telemetry#229: Fix CHANGELOG formatting. Added extra asserts to the test

* open-telemetry#229: Fix formatting

* open-telemetry#229: Fix formatting in GHANGELOG.md

Co-authored-by: iepl <[email protected]>
Co-authored-by: Ievgen Platonov <[email protected]>
@reyang reyang added the comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf label Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reyang @ievgen-platonov