Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventCounter -> Metric API instrumentation #215

Open
cijothomas opened this issue Oct 26, 2021 · 6 comments
Open

EventCounter -> Metric API instrumentation #215

cijothomas opened this issue Oct 26, 2021 · 6 comments
Assignees
Labels
comp:instrumentation.eventcounters Things related to OpenTelemetry.Instrumentation.EventCounters enhancement New feature or request

Comments

@cijothomas
Copy link
Member

An EventCounter listener which can get metrics emitted using EventCounter, and in-turn invoke the new Metric API.
https://docs.microsoft.com/dotnet/core/diagnostics/event-counters

@cijothomas cijothomas added enhancement New feature or request help wanted Extra attention is needed metrics labels Oct 26, 2021
@cijothomas
Copy link
Member Author

@hananiel Assigning this to you since you mentioned interest in contributing this!

@tomkerkhove
Copy link

tomkerkhove commented Jan 11, 2022

Is the current plan to have this in the GA version or only coming later (which is fine)?

@cijothomas
Copy link
Member Author

This is not part of the API/SDK. This will likely be hosted in the -contrib repo, but no timelines yet. (One good thing is, we are not likely blocked by semantic conventions for the stable release of this, once code is ready)

@tomkerkhove
Copy link

Sounds good, thanks for sharing!

@twenzel
Copy link
Contributor

twenzel commented Jan 14, 2022

Looking forward!

@mic-max
Copy link
Contributor

mic-max commented Aug 31, 2022

I am working on making this instrumentation more stable. I will be

  • Add / enable testing
  • Cleaning up implementation
  • Looking into different possible bad scenarios, like enabling the extension twice on the same provider
  • Filtering out metrics covered by other instrumentation (Runtime, Process)
    • Ensure it works in conjunction with other instrumentation so none of the events will be lost
  • Checking for memory leaks and minimize memory footprint as it will be enabled for the full lifetime of most applications that use it
    • Don't allocate memory after startup

@cijothomas cijothomas added comp:instrumentation.eventcounters Things related to OpenTelemetry.Instrumentation.EventCounters and removed help wanted Extra attention is needed labels Oct 26, 2022
@mic-max mic-max removed their assignment Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.eventcounters Things related to OpenTelemetry.Instrumentation.EventCounters enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants