Fix code analysis warnings

Fix code analysis warnings from culture-sensitive string comparisons and an undisposed handler.
open-telemetry · Mar 14, 2023 · a8f86c6 · a8f86c6
1 parent e444046
commit a8f86c6
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/OpenTelemetry.Contrib.Extensions.AWSXRay/Resources/AWSECSResourceDetector.cs b/src/OpenTelemetry.Contrib.Extensions.AWSXRay/Resources/AWSECSResourceDetector.cs
@@ -84,7 +84,7 @@ internal static List<KeyValuePair<string, object>> ExtractMetadataV4ResourceAttr
             return new List<KeyValuePair<string, object>>();
         }
 
-        var httpClientHandler = new HttpClientHandler();
+        using var httpClientHandler = new HttpClientHandler();
         var metadataV4ContainerResponse = ResourceDetectorUtils.SendOutRequest(metadataV4Url, "GET", null, httpClientHandler).Result;
         var metadataV4TaskResponse = ResourceDetectorUtils.SendOutRequest($"{metadataV4Url.TrimEnd('/')}/task", "GET", null, httpClientHandler).Result;
 
@@ -105,9 +105,9 @@ internal static List<KeyValuePair<string, object>> ExtractMetadataV4ResourceAttr
             return new List<KeyValuePair<string, object>>();
         }
 
-        if (!clusterArn.StartsWith("arn:"))
+        if (!clusterArn.StartsWith("arn:", StringComparison.Ordinal))
         {
-            var baseArn = containerArn.Substring(containerArn.LastIndexOf(":"));
+            var baseArn = containerArn.Substring(containerArn.LastIndexOf(":", StringComparison.Ordinal));
             clusterArn = $"{baseArn}:cluster/{clusterArn}";
         }
 
@@ -119,8 +119,8 @@ internal static List<KeyValuePair<string, object>> ExtractMetadataV4ResourceAttr
 
         var launchType = taskResponse.Value<string>("LaunchType") switch
         {
-            string type when "ec2".Equals(type.ToLower()) => AWSSemanticConventions.ValueEcsLaunchTypeEc2,
-            string type when "fargate".Equals(type.ToLower()) => AWSSemanticConventions.ValueEcsLaunchTypeFargate,
+            string type when string.Equals("ec2", type, StringComparison.OrdinalIgnoreCase) => AWSSemanticConventions.ValueEcsLaunchTypeEc2,
+            string type when string.Equals("fargate", type, StringComparison.OrdinalIgnoreCase) => AWSSemanticConventions.ValueEcsLaunchTypeFargate,
             _ => null,
         };
 
@@ -151,7 +151,7 @@ internal static List<KeyValuePair<string, object>> ExtractMetadataV4ResourceAttr
             resourceAttributes.Add(new KeyValuePair<string, object>(AWSSemanticConventions.AttributeEcsTaskRevision, revision));
         }
 
-        if ("awslogs".Equals(containerResponse.Value<string>("LogDriver")))
+        if (string.Equals("awslogs", containerResponse.Value<string>("LogDriver"), StringComparison.Ordinal))
         {
             JObject? logOptions = containerResponse.Value<JObject>("LogOptions");
             if (logOptions != null)