Skip to content

Commit

Permalink
Add support for BatchProcessorOptions in GenevaExporter (#925)
Browse files Browse the repository at this point in the history
* Add support for batchprocessoroptions

* Revert logging

* nits
  • Loading branch information
cijothomas authored Jan 26, 2023
1 parent f784ba3 commit 840a313
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
4 changes: 4 additions & 0 deletions src/OpenTelemetry.Exporter.Geneva/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
([#662](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/662))
([#874](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/874))

* Add support for configuring BatchActivityExportProcessor parameters (via
environment variables) used by GenevaTraceExporter in Linux.
([#925](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/925))

## 1.4.0-rc.1

Released 2022-Dec-19
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,13 @@ private static TracerProviderBuilder AddGenevaTraceExporter(this TracerProviderB
var exporter = new GenevaTraceExporter(options);
if (exporter.IsUsingUnixDomainSocket)
{
return builder.AddProcessor(new BatchActivityExportProcessor(exporter));
var batchOptions = new BatchExportActivityProcessorOptions();
return builder.AddProcessor(new BatchActivityExportProcessor(
exporter,
batchOptions.MaxQueueSize,
batchOptions.ScheduledDelayMilliseconds,
batchOptions.ExporterTimeoutMilliseconds,
batchOptions.MaxExportBatchSize));
}
else
{
Expand Down

0 comments on commit 840a313

Please sign in to comment.