copy error attrs from activity or generate for meter

open-telemetry · Nov 8, 2024 · 765847a · 765847a
1 parent 7f0aba0
commit 765847a
Showing 1 changed file with 15 additions and 0 deletions.
diff --git a/src/OpenTelemetry.Instrumentation.SqlClient/Implementation/SqlClientDiagnosticListener.cs b/src/OpenTelemetry.Instrumentation.SqlClient/Implementation/SqlClientDiagnosticListener.cs
@@ -31,7 +31,9 @@ internal sealed class SqlClientDiagnosticListener : ListenerHandler
         SemanticConventions.AttributeDbSystem,
         SemanticConventions.AttributeDbCollectionName,
         SemanticConventions.AttributeDbNamespace,
+        SemanticConventions.AttributeDbResponseStatusCode,
         SemanticConventions.AttributeDbOperationName,
+        SemanticConventions.AttributeErrorType,
         SemanticConventions.AttributeServerPort,
         SemanticConventions.AttributeServerAddress,
     ];
@@ -288,6 +290,19 @@ private void RecordDuration(Activity? activity, object? payload, bool hasError =
                     }
                 }
             }
+
+            if (hasError)
+            {
+                if (this.exceptionFetcher.TryFetch(payload, out var exception) && exception != null)
+                {
+                    tags.Add(SemanticConventions.AttributeErrorType, exception.GetType().FullName);
+
+                    if (this.exceptionNumberFetcher.TryFetch(exception, out var exceptionNumber))
+                    {
+                        tags.Add(SemanticConventions.AttributeDbResponseStatusCode, exceptionNumber.ToString(CultureInfo.InvariantCulture));
+                    }
+                }
+            }
         }
 
         var duration = activity?.Duration.TotalSeconds ?? this.CalculateDurationFromTimestamp();