[Instrumentation.Runtime] Reintroduce current heap size metric (#683)

open-telemetry · Nov 16, 2022 · 679d871 · 679d871
1 parent b3a921a
commit 679d871
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/src/OpenTelemetry.Instrumentation.Runtime/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.Runtime/CHANGELOG.md
@@ -34,6 +34,9 @@
 
   This does not affect applications targeting .NET Framework.
 
+* Add "process.runtime.dotnet.gc.objects.size" metric
+  ([#683](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/683))
+
 ## 1.0.0
 
 Released 2022-Aug-03

diff --git a/src/OpenTelemetry.Instrumentation.Runtime/RuntimeMetrics.cs b/src/OpenTelemetry.Instrumentation.Runtime/RuntimeMetrics.cs
@@ -48,6 +48,12 @@ static RuntimeMetrics()
             () => GetGarbageCollectionCounts(),
             description: "Number of garbage collections that have occurred since process start.");
 
+        MeterInstance.CreateObservableUpDownCounter(
+            "process.runtime.dotnet.gc.objects.size",
+            () => GC.GetTotalMemory(false),
+            unit: "bytes",
+            description: "Count of bytes currently in use by objects in the GC heap that haven't been collected yet. Fragmentation and other GC committed memory pools are excluded.");
+
 #if NET6_0_OR_GREATER
         MeterInstance.CreateObservableCounter(
             "process.runtime.dotnet.gc.allocations.size",

diff --git a/test/OpenTelemetry.Instrumentation.Runtime.Tests/RuntimeMetricsTests.cs b/test/OpenTelemetry.Instrumentation.Runtime.Tests/RuntimeMetricsTests.cs
@@ -75,6 +75,9 @@ public void GcMetricsTest()
         var gcCountMetric = exportedItems.FirstOrDefault(i => i.Name == "process.runtime.dotnet.gc.collections.count");
         Assert.NotNull(gcCountMetric);
 
+        var totalObjectsSize = exportedItems.FirstOrDefault(i => i.Name == "process.runtime.dotnet.gc.objects.size");
+        Assert.NotNull(totalObjectsSize);
+
 #if NET6_0_OR_GREATER
 
         var gcAllocationSizeMetric = exportedItems.FirstOrDefault(i => i.Name == "process.runtime.dotnet.gc.allocations.size");