Skip to content

Commit

Permalink
Remove references to Jaeger exporter (#1060)
Browse files Browse the repository at this point in the history
  • Loading branch information
Kielek authored Mar 3, 2023
1 parent 25632df commit 0b17dd8
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 20 deletions.
1 change: 0 additions & 1 deletion examples/AspNet/Examples.AspNet.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@
<PackageReference Include="OpenTelemetry.Instrumentation.Http" Version="1.0.0-rc9.14" />
<PackageReference Include="OpenTelemetry.Exporter.Console" Version="$(OpenTelemetryCoreLatestVersion)" />
<PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="$(OpenTelemetryCoreLatestVersion)" />
<PackageReference Include="OpenTelemetry.Exporter.Jaeger" Version="$(OpenTelemetryCoreLatestVersion)" />
<PackageReference Include="OpenTelemetry.Exporter.Zipkin" Version="$(OpenTelemetryCoreLatestVersion)" />
<PackageReference Include="OpenTelemetry.Exporter.Prometheus" Version="1.3.0-rc.2" />
</ItemGroup>
Expand Down
7 changes: 0 additions & 7 deletions examples/AspNet/Global.asax.cs
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,6 @@ protected void Application_Start()

switch (ConfigurationManager.AppSettings["UseExporter"].ToLowerInvariant())
{
case "jaeger":
builder.AddJaegerExporter(jaegerOptions =>
{
jaegerOptions.AgentHost = ConfigurationManager.AppSettings["JaegerHost"];
jaegerOptions.AgentPort = int.Parse(ConfigurationManager.AppSettings["JaegerPort"]);
});
break;
case "zipkin":
builder.AddZipkinExporter(zipkinOptions =>
{
Expand Down
2 changes: 0 additions & 2 deletions examples/AspNet/Web.config
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
<add key="UnobtrusiveJavaScriptEnabled" value="true"/>
<add key="UseExporter" value="console"/>
<add key="UseMetricsExporter" value="console"/>
<add key="JaegerHost" value="localhost"/>
<add key="JaegerPort" value="6831"/>
<add key="ZipkinEndpoint" value="http://localhost:9411/api/v2/spans"/>
<add key="OtlpEndpoint" value="http://localhost:4317"/>
</appSettings>
Expand Down
6 changes: 3 additions & 3 deletions src/OpenTelemetry.Instrumentation.AspNet/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ following shows changes required to your `Web.config` when using IIS web server.

ASP.NET instrumentation must be enabled at application startup. This is
typically done in the `Global.asax.cs` as shown below. This example also sets up
the OpenTelemetry Jaeger exporter, which requires adding the package
[`OpenTelemetry.Exporter.Jaeger`](https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Exporter.Jaeger/README.md)
the OpenTelemetry OTLP exporter, which requires adding the package
[`OpenTelemetry.Exporter.OpenTelemetryProtocol`](https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/README.md)
to the application.

```csharp
Expand All @@ -72,7 +72,7 @@ public class WebApiApplication : HttpApplication
{
this.tracerProvider = Sdk.CreateTracerProviderBuilder()
.AddAspNetInstrumentation()
.AddJaegerExporter()
.AddOtlpExporter()
.Build();
}
protected void Application_End()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ ASP.NET Core instrumentation example:
services.AddOpenTelemetry().WithTracing(x =>
{
x.AddElasticsearchClientInstrumentation();
x.UseJaegerExporter(config => {
// Configure Jaeger
x.AddOtlpExporter(config => {
// Configure OTLP
});
});
```
Expand Down
4 changes: 2 additions & 2 deletions src/OpenTelemetry.Instrumentation.MassTransit/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ services.AddMassTransitHostedService();
services.AddOpenTelemetrySdk(x =>
{
x.AddMassTransitInstrumentation();
x.UseJaegerExporter(config => {
// Configure Jaeger
x.AddOtlpExporter(config => {
// Configure OTLP
});
});
```
Expand Down
6 changes: 3 additions & 3 deletions src/OpenTelemetry.Instrumentation.Quartz/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Automatically instruments the Quartz jobs from
## Supported Frameworks

QuartzNET Instrumentation is only supported when using .NET Framework >=
`net472` and netstandard >= `netstandard2.0`. Quartz`net461` support for
`net472` and .NET Standard >= `netstandard2.0`. Quartz`net461` support for
activity sources has been removed, more information can be found
[here](https://www.quartz-scheduler.net/2021/04/07/quartznet-3-3-released/).

Expand Down Expand Up @@ -45,8 +45,8 @@ public void ConfigureServices(IServiceCollection services)
services.AddOpenTelemetry().WithTracing(x =>
{
x.AddQuartzInstrumentation();
x.UseJaegerExporter(config => {
// Configure Jaeger
x.AddOtlpExporter(config => {
// Configure OTLP
});
});
```
Expand Down

0 comments on commit 0b17dd8

Please sign in to comment.