Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cartservice] Update to .NET 7 #942

Merged
merged 3 commits into from
Jun 21, 2023

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Jun 15, 2023

Changes

Update target and docker images to .NET7 for cartservice.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • [ ] Appropriate documentation updates in the docs N/A
  • [ ] Appropriate Helm chart updates in the helm-charts N/A

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@Kielek Kielek requested a review from a team June 15, 2023 05:20
@cartersocha
Copy link
Contributor

The cart service is constantly restarting on my mac m2. Getting an error message like " Unhandled exception. System.TypeInitializationException: The type initializer for 'OpenTelemetry.SuppressInstrumentationScope' threw an exception.
cart-service | ---> System.NullReferenceException: Object reference not set to an instance of an object."

I can share the more detailed message if needed

@Kielek
Copy link
Contributor Author

Kielek commented Jun 16, 2023

@cartersocha, I was able to reproduce. I am not sure how I missed that while testing (probably I have made mistake while building new docker image).

Bug reported under open-telemetry/opentelemetry-dotnet#4600

Locally, I have removed Trimming option. It will increase image size, but it is working correctly.

Copy link
Contributor

@cartersocha cartersocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working now thanks!

@Kielek
Copy link
Contributor Author

Kielek commented Jun 21, 2023

@cartersocha, trimming was working on .NET 6 by accident (it is producing warnings). There is a plan to make a support for trimming operation in OpenTelemetry .NET for 1.6 version (tentatively scheduled on November).

It should be good to merge for now.

@cartersocha cartersocha merged commit 846ae2d into open-telemetry:main Jun 21, 2023
@Kielek Kielek deleted the cartservice-net7 branch June 21, 2023 16:41
AlexanderWert pushed a commit to AlexanderWert/opentelemetry-demo that referenced this pull request Jul 24, 2023
* [cartservice] Update to .NET 7

* Add changelog entry

* Avoid trimming application due
open-telemetry/opentelemetry-dotnet#4600
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* [cartservice] Update to .NET 7

* Add changelog entry

* Avoid trimming application due
open-telemetry/opentelemetry-dotnet#4600
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants