[chore] update kubernetes manifest #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre Tessier <[email protected]>
Signed-off-by: Pierre Tessier <[email protected]>
puckpuck
changed the title
Signed-off-by: Pierre Tessier <[email protected]>
… update_kubernetes_manifest
julianocosta89
approved these changes
Apr 18, 2023
AlexanderWert
pushed a commit
to AlexanderWert/opentelemetry-demo
that referenced
this pull request
Jul 24, 2023
* update k8s manifest to latest Signed-off-by: Pierre Tessier <[email protected]> * update k8s manifest to latest Signed-off-by: Pierre Tessier <[email protected]> * add copyright to generated k8s manifests Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]>
|
Hello! I hope you're doing well. I noticed that in your configuration, "tcp-" is added before the service port name instead of "grpc-". For instance, the opentelemetry-demo-paymentservice changes from "service" to "tcp-service". I observed that in the GoogleCloudPlatform/microservices-demo, it's written as "grpc". Could there be any potential issues if I change it to "grpc-" instead of "tcp-"? The reason I'm considering this change is that currently, I'm only detecting TCP traffic and not seeing any GRPC traffic in Istio. Your insights on this would be greatly appreciated! |
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* update k8s manifest to latest Signed-off-by: Pierre Tessier <[email protected]> * update k8s manifest to latest Signed-off-by: Pierre Tessier <[email protected]> * add copyright to generated k8s manifests Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a Helm chart released for 1.4 of the demo, this is an output of that release. Also forces the namespace to be
otel-demoand when combined with a docs change will fix #840CHANGELOG.mdupdated to document new feature additions