Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add license check #825

Merged
merged 10 commits into from
Apr 7, 2023
Merged

Add license check #825

merged 10 commits into from
Apr 7, 2023

Conversation

austinlparker
Copy link
Member

Fixes #233

This PR adds two new make targets (checklicense and addlicense) and updates the GitHub PR checks to scan for valid copyright/license declarations.

@austinlparker austinlparker requested a review from a team April 5, 2023 13:40
trask
trask reviewed Apr 5, 2023
View reviewed changes
.licenserc.json Outdated Show resolved Hide resolved
@puckpuck
Copy link
Contributor

puckpuck commented Apr 6, 2023

Should we include .yamllint, *.sh, Makefile in the list of license check patterns?

@puckpuck
Copy link
Contributor

puckpuck commented Apr 6, 2023

Also need to include *.gradle, Gemfile, *.gradle.kts, and *.kt

There's also a grafana.ini file we may want to include in this, but I'm indifferent if we don't.

Going over the changes, I noticed a couple of Dockerfile that had both the short form and long form copyright notices. ad, cart, checkout, currency, loadgenerator, payment, productcatalog, and recommendation, all have both notices in their header. I assume this may be because of extra blank lines in the file.

@julianocosta89
Copy link
Member

Should we include .yamllint, *.sh, Makefile in the list of license check patterns?

+1 to yes!

I don't mind the yamllint, but *.sh and Makefile were pretty much built from scratch.

@cartersocha
Copy link
Contributor

Lgtm outside of Pierre's and juliano's comment

@cartersocha cartersocha added the in-progress This issue is actively being worked on label Apr 6, 2023
@fatsheep9146
Copy link
Contributor

some small nits

@austinlparker austinlparker merged commit deaf1f6 into open-telemetry:main Apr 7, 2023
@austinlparker austinlparker deleted the addLicenseCheck branch April 7, 2023 17:40
JaredTan95 pushed a commit to openinsight-proj/opentelemetry-demo that referenced this pull request Apr 10, 2023
@Frapschen @devrimdemiroz
@reyang @cartersocha @julianocosta89 @dependabot @puckpuck @austinlparker @martinkuba @bshetti @brettmc @fatsheep9146
version bump up to 1.4.0 beta (#7)
5473c7c 
* Changelog entry for PR 797 (open-telemetry#803)

* Changelog entry for PR 797

* Changelog ordered

* lint fix

* Move Michael Maxwell to Emeritus (open-telemetry#800)

Co-authored-by: Carter Socha <[email protected]>
Co-authored-by: Juliano Costa <[email protected]>

* Bump actions/stale from 7 to 8 (open-telemetry#804)

Bumps [actions/stale](https://github.com/actions/stale) from 7 to 8.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v7...v8)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* use absolute path (open-telemetry#806)

Signed-off-by: Pierre Tessier <[email protected]>

* use yamllint 1.3.0 (open-telemetry#807)

Signed-off-by: Pierre Tessier <[email protected]>

* [chore] add kubernetes manifest (open-telemetry#791)

* add kubernetes manifest

Signed-off-by: Pierre Tessier <[email protected]>

* add kubernetes manifest

Signed-off-by: Pierre Tessier <[email protected]>

* use absolute path

Signed-off-by: Pierre Tessier <[email protected]>

---------

Signed-off-by: Pierre Tessier <[email protected]>
Co-authored-by: Juliano Costa <[email protected]>

* Cart Service - minor cleanup (open-telemetry#801)

* Cart Service - minor cleanup

* fix file encoding

Signed-off-by: Pierre Tessier <[email protected]>

---------

Signed-off-by: Pierre Tessier <[email protected]>
Co-authored-by: Pierre Tessier <[email protected]>

* [frontend] update JS SDKs (open-telemetry#805)

* update JS SDKs

Signed-off-by: Pierre Tessier <[email protected]>

* update JS SDKs for frontend

Signed-off-by: Pierre Tessier <[email protected]>

* fix formatting

Signed-off-by: Pierre Tessier <[email protected]>

---------

Signed-off-by: Pierre Tessier <[email protected]>
Co-authored-by: Juliano Costa <[email protected]>
Co-authored-by: Austin Parker <[email protected]>

* Otlp env variables (open-telemetry#809)

* standardize OTEL_* env vars

Signed-off-by: Pierre Tessier <[email protected]>

* standardize OTEL_* env vars

Signed-off-by: Pierre Tessier <[email protected]>

---------

Signed-off-by: Pierre Tessier <[email protected]>
Co-authored-by: Juliano Costa <[email protected]>

* [frontend] fix http.status_code on error (open-telemetry#810)

* fix http.status_code on error

Signed-off-by: Pierre Tessier <[email protected]>

* only end span when synthetic

Signed-off-by: Pierre Tessier <[email protected]>

* fix http.status_code on error

Signed-off-by: Pierre Tessier <[email protected]>

---------

Signed-off-by: Pierre Tessier <[email protected]>

* Fix to shipping calculation (open-telemetry#814)

* reduce kafka mem allocation (open-telemetry#798)

* add kafka mem allocation to changelog (open-telemetry#817)

* Changed web tracer to use batch processor (open-telemetry#819)

* Updated ENV_PLATFORM flag (open-telemetry#818)

* Added elastic's forked opentelemetry demo repo (open-telemetry#813)

* Update collector (open-telemetry#822)

* use async php runtime (open-telemetry#823)

* use async php runtime
To better demonstrate PHP's capabilities, use an async runtime (react/http). This means that
batch exporters (traces and metrics) are long-lived and more efficient, and they can now use
export delays to only send batches after the configured time has elapsed.
Update auto-instrumentation extension to install from PECL (the preferred mechanism, which we've
just set up), and bump other dependencies to their latest beta versions.

* update changelog

* Add license check (open-telemetry#825)

* adding license check

* add/update copyrights

* add checklicense to gh checks

* add make target to add license

* fixup

* swap to short form license

* add copyright to yaml

* and the rest of the yaml

* fixup

* address comments

* fix prometheus scrape bug (open-telemetry#827)

Signed-off-by: Ziqi Zhao <[email protected]>
Co-authored-by: Austin Parker <[email protected]>

* prep for beta (open-telemetry#828)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Pierre Tessier <[email protected]>
Signed-off-by: Ziqi Zhao <[email protected]>
Co-authored-by: Devrim Demiroz <[email protected]>
Co-authored-by: Reiley Yang <[email protected]>
Co-authored-by: Carter Socha <[email protected]>
Co-authored-by: Juliano Costa <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Pierre Tessier <[email protected]>
Co-authored-by: Austin Parker <[email protected]>
Co-authored-by: Martin Kuba <[email protected]>
Co-authored-by: Bahubali Shetti <[email protected]>
Co-authored-by: Brett McBride <[email protected]>
Co-authored-by: Ziqi Zhao <[email protected]>
juliangiuca pushed a commit to juliangiuca/opentelemetry-demo that referenced this pull request Apr 12, 2023
@austinlparker @juliangiuca
Add license check (open-telemetry#825)
46d0a9d 
* adding license check

* add/update copyrights

* add checklicense to gh checks

* add make target to add license

* fixup

* swap to short form license

* add copyright to yaml

* and the rest of the yaml

* fixup

* address comments
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@austinlparker
Add license check (open-telemetry#825)
23f44ee 
* adding license check

* add/update copyrights

* add checklicense to gh checks

* add make target to add license

* fixup

* swap to short form license

* add copyright to yaml

* and the rest of the yaml

* fixup

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fatsheep9146 fatsheep9146 fatsheep9146 left review comments

@trask trask trask left review comments

@cartersocha cartersocha cartersocha approved these changes

@jack-berg jack-berg Awaiting requested review from jack-berg

@mateuszrzeszutek mateuszrzeszutek Awaiting requested review from mateuszrzeszutek

Assignees
No one assigned
Labels
in-progress This issue is actively being worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ci] add license lint check
6 participants
@austinlparker @puckpuck @julianocosta89 @cartersocha @fatsheep9146 @trask