-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FrontendProxy] Add tracing to Envoy #613
[FrontendProxy] Add tracing to Envoy #613
Conversation
We should add envoy to the current services architecture doc. Especially if there's a span coming from it Should we add a simple envoy service doc with config instructions too? |
@cartersocha Not sure what exactly to write, but I've added the "how to" make Envoy produce spans. |
I'm seeing errors on the frontend and checkout service |
Not sure why the shipping service is throwing issues. "13 INTERNAL: shipping quote failure: failed to get shipping quote: rpc error: code = Unknown desc = error sending request for url (http://quoteservice:8090/getquote): error trying to connect: dns error: failed to lookup address information: Name does not resolve" |
A system prune cleared up the errors but I'm not seeing an envoy span in any trace. I see envoy as an orphan span currently and the main trace doesn't have it present |
@cartersocha true! |
I see! lgtm. This is where it would be nice to have non synthetic requests set the attribute to filter on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a note in the envoy services doc at the top saying only non synthetic requests will trigger the envoy tracing.
Lgtm otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit. everything works as expected. 👍
* Add tracing to Envoy * Changelog * yamllint * lint * Add doc * Add note to doc * Move env var definition
Changes
As Envoy supports OpenTelemetry, I believe it would be great if we could use it.
https://www.envoyproxy.io/docs/envoy/latest/start/sandboxes/opentelemetry
This PR adds the configuration required to add tracing to Envoy.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.