Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shippingservice] apply OTEL_RESOURCE_ATTRIBUTES #594

Merged
merged 2 commits into from
Nov 21, 2022
Merged

[shippingservice] apply OTEL_RESOURCE_ATTRIBUTES #594

merged 2 commits into from
Nov 21, 2022

Conversation

ty-elastic
Copy link
Contributor

Fixes #593

Changes

  • use EnvResourceDetector to load OTEL_RESOURCE_ATTRIBUTES
  • merge to existing trace resources

@ty-elastic ty-elastic requested a review from a team November 18, 2022 21:10
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 18, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ty-elastic / name: Ty Bekiares (0450c09)

@cartersocha
Copy link
Contributor

Thanks for the bug fix!

Please sign the cla at your earliest convenience so we don’t get blocked merging post reviews.

@ty-elastic
Copy link
Contributor Author

@cartersocha , thx! i fixed the commit ownership.

julianocosta89
julianocosta89 approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

julianocosta89
julianocosta89 reviewed Nov 21, 2022
View reviewed changes
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ty-elastic could you also update https://github.com/open-telemetry/opentelemetry-demo/blob/main/docs/services/shippingservice.md#initializing-tracing?

@ty-elastic
Copy link
Contributor Author

@julianocosta89 , thanks! I updated the docs as appropriate.

@austinlparker austinlparker merged commit 265aefe into open-telemetry:main Nov 21, 2022
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@ty-elastic @austinlparker
[shippingservice] apply OTEL_RESOURCE_ATTRIBUTES (open-telemetry#594)
d4e2bff 
Co-authored-by: Austin Parker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianocosta89 julianocosta89 julianocosta89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[shippingservice] ignores OTEL_RESOURCE_ATTRIBUTES
4 participants
@ty-elastic @cartersocha @julianocosta89 @austinlparker