Improve build times for JS and PHP #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
approved these changes
Oct 31, 2022
puckpuck
approved these changes
Oct 31, 2022
austinlparker
changed the title
|
@austinlparker this PR broke the PHP traces. |
|
That's weird, it worked locally. |
|
Would folks be interested in a CI job which captures traces across all services as part of the integration test? (I think integration test which covers telemetry correctness is an amazing thing to demonstrate, seems a good fit) |
|
Yeah, that’d be good if we could get build times down… I don’t think it’s reasonable until then though. Sent from my iPhoneOn Nov 2, 2022, at 7:25 PM, Reiley Yang ***@***.***> wrote:
Would folks be interested in a CI job which captures traces across all services as part of the integration test? (I think integration test which covers telemetry correctness is an amazing thing to demonstrate, seems a good fit)
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Merged
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* update JS gRPC * remove grpc deps from quoteservice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In support of #458, this PR is making an attempt to improve build times by optimizing gRPC libs where possible/easy.