[frontendproxy] image packaging #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # docker-compose.yml # src/frontendproxy/envoy.tmpl.yaml # src/frontendproxy/envoy.yaml.tmpl
austinlparker
approved these changes
Oct 22, 2022
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* top button goes to /feature * package frontendproxy image * set frontendproxy port to 8080 * use proxy url instead * use proxy url instead * use proxy url instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Copies template file into image, and uses an ENTRYPOINT to start. This removes the need to mount volumes or specify a command for the image to start, enabling easier deployment with Helm
Also sets the port to 8080 instead of 80 due to the need for privileged access in some scenarios.