-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[shippingservice] add resource data #504
[shippingservice] add resource data #504
Conversation
This is what I have at the moment: @TommyCpp and @GaryPWhite any ideas how can I add I've played with the ones documented here, but no luck: |
Can you update the shippingservice docs with this as well? |
Also asked for some insights in the otel-rust slack channel. |
open-telemetry/opentelemetry-rust#899 should do the trick |
I need to double-check and see if we can release a minor version to include this change but feel free to copy-paste the code in the PR I linked above (or I can do it as a follow-up PR if that's preferable) |
Did the upstream change ever go in? Could we update deps in lieu of this PR? |
@austinlparker updated. |
* Add resource data to shipping service * add changelog * Update shippingservice docs * Cargo update and formatting
Fixes #.
Changes
Shipping Service has no resource data.
I've used the Resource Detectors in order to add some data to it.
Unfortunately
telemetry.sdk
data is not part of it.Sending the PR to maybe get some insights from the everyone.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes