Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom attributes and spans for FeatureFlag service #371

Merged
merged 7 commits into from
Sep 19, 2022

Conversation

joshleecreates
Copy link
Contributor

Fixes #328.

Changes

Adds a custom span when new feature flags are created via the UI, and adds custom attributes for the feature flag to the auto instrumentation span on the grpc service.

@joshleecreates joshleecreates requested a review from a team September 16, 2022 19:23
@cartersocha
Copy link
Contributor

Please update the change log and attribute doc too!

docs/manual_span_attributes.md

joshleecreates added a commit to joshleecreates/opentelemetry-demo that referenced this pull request Sep 19, 2022
joshleecreates added a commit to joshleecreates/opentelemetry-demo that referenced this pull request Sep 19, 2022
@austinlparker
Copy link
Member

Can we get the failing check cleaned up?

Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

CHANGELOG.md Outdated Show resolved Hide resolved
@cartersocha cartersocha merged commit b9dd425 into open-telemetry:main Sep 19, 2022
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[featureflag]: flag name and status on spans
4 participants