Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gradlew to LF line-endings #363

Merged
merged 9 commits into from
Sep 14, 2022
Merged

Fix gradlew to LF line-endings #363

merged 9 commits into from
Sep 14, 2022

Conversation

mic-max
Copy link
Contributor

@mic-max mic-max commented Sep 13, 2022

Fixes #77

Now if someone on Windows clones the repository no additional steps need to be taken.

Changes

  • Added .gitattributes file with wildcard text files set to auto line ending and specifically just gradlew file to LF
  • git clone clone-tips https://github.com/mic-max/opentelemetry-demo-webstore.git
  • docker compose up adservice --build

Note: --build was included here just to make sure it is actually building and not using the cloud hosted image since there's some new work happening with that.

image

@mic-max mic-max marked this pull request as ready for review September 13, 2022 23:25
@mic-max mic-max requested a review from a team September 13, 2022 23:25
@cartersocha
Copy link
Contributor

🦞

@cartersocha cartersocha merged commit e9913ed into open-telemetry:main Sep 14, 2022
@mic-max mic-max deleted the clone-tips branch September 14, 2022 17:35
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix gradlew commands on Windows
3 participants