-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add metrics to satisfy http server semantic conventions #232
add metrics to satisfy http server semantic conventions #232
Conversation
Signed-off-by: Ziqi Zhao <[email protected]>
Signed-off-by: Ziqi Zhao <[email protected]>
Qn - how does the Go front end export this? Is it done via OTLP exporter? Or via Prometheus directly? |
never mind, I think i got the answer from https://github.com/open-telemetry/opentelemetry-demo/blob/main/src/frontend/main.go#L108 |
Yes, via OTLP exporter |
@fatsheep9146, could you update the changelog and then I'll merge |
Trying to get better about that upfront 😄. Do any docs need to be updated? I think we have a centralized metric doc but it's a bit immature |
Would this PR be in conflict with #236 which is replacing frontend with a Next.js based service? |
Yes, I think @puckpuck is right, since the whole frontend service is replaces with Next.js implementation. Should I close this pr ? @cartersocha |
Yes let’s wait for the new front end |
@cartersocha I think #70 , #49 should also be modified or close to avoid confusion |
Roger that. Thanks for calling them out. Closed for now |
Signed-off-by: Ziqi Zhao [email protected]
related #70
Changes
Add more metrics to satisfy http server metrics semantic coventions
http.server.response.size dashboard demo
http.server.active_requests dashboard demo